Rename WebKit target to WebKitLegacy and rename WebKit2 target to WebKit
This is next up for me after we land bug #174490. We should obviously do this for 2.18 as otherwise it would be confusing to have WebKit2 build targets when we no longer have a WebKit2.
I don't think build targets are that important to be honest. There's always going to be confusion considering that our product name is still WebKit2GTK, so tarball name, pkg-config file, documentation, etc. are going to use WebKit2 forever or until we release WebKit3 :-) I'm fine with changing the build targets, but I don't think it's a so urgent task, considering we have real bugs, and even build options like web crypto we want to enable still to do for 2.18.
(In reply to Carlos Garcia Campos from comment #2) > I don't think build targets are that important to be honest. There's always > going to be confusion considering that our product name is still WebKit2GTK, > so tarball name, pkg-config file, documentation, etc. are going to use > WebKit2 forever or until we release WebKit3 No, we should get rid of the 2 from our GTK+ 4 API, then we can leave it behind forever once we drop GTK+ 3 support. Probably will be many years before we do that, but let's not carry the 2 into our future APIs.
Well this was really hard. I have something that built locally, somehow. No doubt EWS will not be very happy, but only one way to find out. (In reply to Michael Catanzaro from comment #3) > No, we should get rid of the 2 from our GTK+ 4 API, then we can leave it > behind forever once we drop GTK+ 3 support. Probably will be many years > before we do that, but let's not carry the 2 into our future APIs. I no longer have a strong opinion about this, though I still prefer to drop the 2 from our next API version.
Created attachment 320802 [details] Patch
*** Bug 174488 has been marked as a duplicate of this bug. ***
Created attachment 320840 [details] Patch
Created attachment 320841 [details] Patch
Created attachment 320843 [details] Patch
Created attachment 320845 [details] Patch
Hey Alex, thanks for the r+. Unfortunately it's going to be broken for sure on Mac CMake, since I don't have an EWS to test against. Any chance you or someone else who uses Mac CMake would want to give it a try?
Unfortunately I'm stumped by Windows too. Clearly something is wrong with WebCoreTestSupport, but the error message is pretty cryptic: WebCoreTestSupport.vcxproj -> C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\lib32\WebCoreTestSupport.lib C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(123,5): error MSB3073: The command "setlocal [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacyGUID.vcxproj] C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(123,5): error MSB3073: call ..\..\DerivedSources\WebKitLegacy\preBuild.cmd [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacyGUID.vcxproj] C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(123,5): error MSB3073: if %errorlevel% neq 0 goto :cmEnd [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacyGUID.vcxproj] C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(123,5): error MSB3073: :cmEnd [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacyGUID.vcxproj] C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(123,5): error MSB3073: endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacyGUID.vcxproj] C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(123,5): error MSB3073: :cmErrorLevel [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacyGUID.vcxproj] C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(123,5): error MSB3073: exit /b %1 [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacyGUID.vcxproj] C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(123,5): error MSB3073: :cmDone [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacyGUID.vcxproj] C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(123,5): error MSB3073: if %errorlevel% neq 0 goto :VCEnd [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacyGUID.vcxproj] C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(123,5): error MSB3073: :VCEnd" exited with code 2. [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacyGUID.vcxproj]
Ah I missed a spot trying to change WebKitGUID -> WebKitLegacyGUID. Maybe that is the problem with Windows.
Created attachment 320855 [details] Patch
(In reply to Michael Catanzaro from comment #13) > Ah I missed a spot trying to change WebKitGUID -> WebKitLegacyGUID. Maybe > that is the problem with Windows. Nope....
One thing I notice is that it seems like the change for generate-webkitversion.pl in PlatformWin.cmake may be missing one conversion to WEBKITLEGACY_DIR. It seems like the script location wasn't updated in the COMMAND like it was in MAIN_DEPENDENCY.
That doesn't seem to be the issue with WebKitLegacyGUID.lib though. I hit that after I'd run ninja -v and run each of the pieces of the command for the library link manually which seemed to work despite it failing as part of the build which then made the build go further.
Thanks Stephan. There's some more stale uses of WEBKIT_DIR under WebKitLegacy_INCLUDE_DIRECTORIES as well. I'll upload a patch with the stale uses of WEBKIT_DIR fixed. I don't expect it to fix WebKitLegacyGUID.lib, but it'll be one step closer.
Created attachment 321112 [details] Patch
Ah, now GTK and WPE don't build... that's the problem with trying to land a huge patch like this. :/ I will fix those later, once we've got Windows working.
I don't know if this makes a difference for the build, but in WebKitLegacy/PlatformWin.cmake in the section doing the PRE_BUILD_COMMAND, the xcopy is modified to use \"${FORWARDING_HEADERS_DIR}/WebKitLegacy\" rather than \"${FORWARDING_HEADERS_DIR}/WebKit\", but the MAKE_DIRECTORY still makes ${FORWARDING_HEADERS_DIR}/WebKit rather than ${FORWARDING_HEADERS_DIR}/WebKitLegacy
When running the generated prebuild from a shell, they just seem to sit forever on my machine. When I took out the >nul 2>nul, I got the "does xxx specify a file name or directory name on the target" prompt.
Created attachment 321136 [details] Some modifications to existing patch to try to make Windows happy This has some additional modifications for making Windows happy. Looking to see if windows EWS is okay with it.
Attachment 321136 [details] did not pass style-queue: ERROR: Tools/MiniBrowser/win/MiniBrowserWebHost.h:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/DumpRenderTree/win/HistoryDelegate.cpp:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/DumpRenderTree/win/WorkQueueItemWin.cpp:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 64 files If any of these errors are false positives, please file a bug against check-webkit-style.
That seems to have made the win bot happy.
Yes indeed, thanks Stephan! I'll try to fix GTK and WPE now and then land this. Unfortunately since Mac CMake does not have an EWS and there were no volunteers to look into it, that will have to be handled as a follow-up.
Comment on attachment 321136 [details] Some modifications to existing patch to try to make Windows happy View in context: https://bugs.webkit.org/attachment.cgi?id=321136&action=review > Source/WebKit/PlatformGTK.cmake:410 > + ${DERIVED_SOURCES_WEBKIT2GTK_DIR}/WebKitResourcesGResourceBundle.c Not sure if you're planning on going after this one too but there's still a WEBKIT2GTK hanging out. Other than that looking forward to this getting sorted.
Created attachment 321150 [details] Patch
(In reply to Don Olmstead from comment #27) > > Source/WebKit/PlatformGTK.cmake:410 > > + ${DERIVED_SOURCES_WEBKIT2GTK_DIR}/WebKitResourcesGResourceBundle.c > > Not sure if you're planning on going after this one too but there's still a > WEBKIT2GTK hanging out. > > Other than that looking forward to this getting sorted. Yeah, the problem with that is... it's part of the name of our API. We'll have to consider whether to change that separately.
Committed r222194: <http://trac.webkit.org/changeset/222194>
Although the Windows EWS passed, the release buildbot is failing: Creating library C:/cygwin/home/buildbot/slave/win-release/build/WebKitBuild/Release/lib32/WebKit.lib and object C:/cygwin/home/buildbot/slave/win-release/build/WebKitBuild/Release/lib32/WebKit.exp WebInspectorClient.obj : error LNK2001: unresolved external symbol "struct WTFLogChannel * __cdecl WebCore::notImplementedLoggingChannel(void)" (?notImplementedLoggingChannel@WebCore@@YAPAUWTFLogChannel@@XZ) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebChromeClient.obj : error LNK2001: unresolved external symbol "struct WTFLogChannel * __cdecl WebCore::notImplementedLoggingChannel(void)" (?notImplementedLoggingChannel@WebCore@@YAPAUWTFLogChannel@@XZ) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebContextMenuClient.obj : error LNK2001: unresolved external symbol "struct WTFLogChannel * __cdecl WebCore::notImplementedLoggingChannel(void)" (?notImplementedLoggingChannel@WebCore@@YAPAUWTFLogChannel@@XZ) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebEditorClient.obj : error LNK2001: unresolved external symbol "struct WTFLogChannel * __cdecl WebCore::notImplementedLoggingChannel(void)" (?notImplementedLoggingChannel@WebCore@@YAPAUWTFLogChannel@@XZ) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebFrameLoaderClient.obj : error LNK2001: unresolved external symbol "struct WTFLogChannel * __cdecl WebCore::notImplementedLoggingChannel(void)" (?notImplementedLoggingChannel@WebCore@@YAPAUWTFLogChannel@@XZ) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] AccessibleBase.obj : error LNK2001: unresolved external symbol "struct WTFLogChannel * __cdecl WebCore::notImplementedLoggingChannel(void)" (?notImplementedLoggingChannel@WebCore@@YAPAUWTFLogChannel@@XZ) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebDownload.obj : error LNK2001: unresolved external symbol "struct WTFLogChannel * __cdecl WebCore::notImplementedLoggingChannel(void)" (?notImplementedLoggingChannel@WebCore@@YAPAUWTFLogChannel@@XZ) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebView.obj : error LNK2001: unresolved external symbol "struct WTFLogChannel * __cdecl WebCore::notImplementedLoggingChannel(void)" (?notImplementedLoggingChannel@WebCore@@YAPAUWTFLogChannel@@XZ) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] PluginView.obj : error LNK2001: unresolved external symbol "struct WTFLogChannel * __cdecl WebCore::notImplementedLoggingChannel(void)" (?notImplementedLoggingChannel@WebCore@@YAPAUWTFLogChannel@@XZ) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] PluginView.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: static bool __cdecl WTF::AtomicStringImpl::isInAtomicStringTable(class WTF::StringImpl *)" (__imp_?isInAtomicStringTable@AtomicStringImpl@WTF@@SA_NPAVStringImpl@2@@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebFrameLoaderClient.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: static bool __cdecl WTF::AtomicStringImpl::isInAtomicStringTable(class WTF::StringImpl *)" (__imp_?isInAtomicStringTable@AtomicStringImpl@WTF@@SA_NPAVStringImpl@2@@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] DOMCoreClasses.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: static bool __cdecl WTF::AtomicStringImpl::isInAtomicStringTable(class WTF::StringImpl *)" (__imp_?isInAtomicStringTable@AtomicStringImpl@WTF@@SA_NPAVStringImpl@2@@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] DOMHTMLClasses.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: static bool __cdecl WTF::AtomicStringImpl::isInAtomicStringTable(class WTF::StringImpl *)" (__imp_?isInAtomicStringTable@AtomicStringImpl@WTF@@SA_NPAVStringImpl@2@@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebFrame.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: static bool __cdecl WTF::AtomicStringImpl::isInAtomicStringTable(class WTF::StringImpl *)" (__imp_?isInAtomicStringTable@AtomicStringImpl@WTF@@SA_NPAVStringImpl@2@@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebView.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: static bool __cdecl WTF::AtomicStringImpl::isInAtomicStringTable(class WTF::StringImpl *)" (__imp_?isInAtomicStringTable@AtomicStringImpl@WTF@@SA_NPAVStringImpl@2@@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] DOMHTMLClasses.obj : error LNK2019: unresolved external symbol "public: bool __thiscall WebCore::Element::fastAttributeLookupAllowed(class WebCore::QualifiedName const &)const " (?fastAttributeLookupAllowed@Element@WebCore@@QBE_NABVQualifiedName@2@@Z) referenced in function "public: class WTF::AtomicString const & __thiscall WebCore::Element::attributeWithoutSynchronization(class WebCore::QualifiedName const &)const " (?attributeWithoutSynchronization@Element@WebCore@@QBEABVAtomicString@WTF@@ABVQualifiedName@2@@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] DOMHTMLClasses.obj : error LNK2001: unresolved external symbol "private: static unsigned int WebCore::NoEventDispatchAssertion::s_count" (?s_count@NoEventDispatchAssertion@WebCore@@0IA) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebView.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) private: static unsigned long JSC::DisallowGC::s_scopeReentryCount" (__imp_?s_scopeReentryCount@DisallowGC@JSC@@0KA) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] PluginView.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) private: static unsigned long JSC::DisallowGC::s_scopeReentryCount" (__imp_?s_scopeReentryCount@DisallowGC@JSC@@0KA) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] PluginViewWin.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) private: static unsigned long JSC::DisallowGC::s_scopeReentryCount" (__imp_?s_scopeReentryCount@DisallowGC@JSC@@0KA) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebFrameLoaderClient.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) private: static unsigned long JSC::DisallowGC::s_scopeReentryCount" (__imp_?s_scopeReentryCount@DisallowGC@JSC@@0KA) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebCoreStatistics.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) private: static unsigned long JSC::DisallowGC::s_scopeReentryCount" (__imp_?s_scopeReentryCount@DisallowGC@JSC@@0KA) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebFrame.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) private: static unsigned long JSC::DisallowGC::s_scopeReentryCount" (__imp_?s_scopeReentryCount@DisallowGC@JSC@@0KA) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebJavaScriptCollector.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) private: static unsigned long JSC::DisallowGC::s_scopeReentryCount" (__imp_?s_scopeReentryCount@DisallowGC@JSC@@0KA) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebScriptWorld.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) private: static unsigned long JSC::DisallowGC::s_scopeReentryCount" (__imp_?s_scopeReentryCount@DisallowGC@JSC@@0KA) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebView.obj : error LNK2019: unresolved external symbol "public: __thiscall WebCore::GDIObjectCounter::GDIObjectCounter(class WTF::String const &)" (??0GDIObjectCounter@WebCore@@QAE@ABVString@WTF@@@Z) referenced in function "public: void __thiscall WebView::paint(struct HDC__ *,long)" (?paint@WebView@@QAEXPAUHDC__@@J@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebView.obj : error LNK2019: unresolved external symbol "public: __thiscall WebCore::GDIObjectCounter::~GDIObjectCounter(void)" (??1GDIObjectCounter@WebCore@@QAE@XZ) referenced in function "public: void __thiscall WebView::paint(struct HDC__ *,long)" (?paint@WebView@@QAEXPAUHDC__@@J@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebView.obj : error LNK2019: unresolved external symbol "void __cdecl WebCore::initializeLogChannelsIfNecessary(class std::optional<class WTF::String>)" (?initializeLogChannelsIfNecessary@WebCore@@YAXV?$optional@VString@WTF@@@std@@@Z) referenced in function "public: virtual long __stdcall WebView::initWithFrame(struct tagRECT,wchar_t *,wchar_t *)" (?initWithFrame@WebView@@UAGJUtagRECT@@PA_W1@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] PluginPackage.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall JSC::ThrowScope::ThrowScope(class JSC::VM &,struct JSC::ExceptionEventLocation)" (__imp_??0ThrowScope@JSC@@QAE@AAVVM@1@UExceptionEventLocation@1@@Z) referenced in function "public: class JSC::JSValue __thiscall JSC::JSObject::get(class JSC::ExecState *,class JSC::PropertyName)const " (?get@JSObject@JSC@@QBE?AVJSValue@2@PAVExecState@2@VPropertyName@2@@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] PluginPackage.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall JSC::ThrowScope::~ThrowScope(void)" (__imp_??1ThrowScope@JSC@@QAE@XZ) referenced in function "public: class JSC::JSValue __thiscall JSC::JSObject::get(class JSC::ExecState *,class JSC::PropertyName)const " (?get@JSObject@JSC@@QBE?AVJSValue@2@PAVExecState@2@VPropertyName@2@@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] PluginPackage.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall JSC::CatchScope::CatchScope(class JSC::VM &,struct JSC::ExceptionEventLocation)" (__imp_??0CatchScope@JSC@@QAE@AAVVM@1@UExceptionEventLocation@1@@Z) referenced in function "bool __cdecl WebCore::NPN_Evaluate(struct _NPP *,struct NPObject *,struct _NPString *,struct _NPVariant *)" (?NPN_Evaluate@WebCore@@YA_NPAU_NPP@@PAUNPObject@@PAU_NPString@@PAU_NPVariant@@@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] PluginPackage.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall JSC::CatchScope::~CatchScope(void)" (__imp_??1CatchScope@JSC@@QAE@XZ) referenced in function "bool __cdecl WebCore::NPN_Evaluate(struct _NPP *,struct NPObject *,struct _NPString *,struct _NPVariant *)" (?NPN_Evaluate@WebCore@@YA_NPAU_NPP@@PAUNPObject@@PAU_NPString@@PAU_NPVariant@@@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] PluginPackageWin.obj : error LNK2001: unresolved external symbol "struct WTFLogChannel WebCore::LogPlugins" (?LogPlugins@WebCore@@3UWTFLogChannel@@A) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] PluginStream.obj : error LNK2001: unresolved external symbol "struct WTFLogChannel WebCore::LogPlugins" (?LogPlugins@WebCore@@3UWTFLogChannel@@A) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] PluginView.obj : error LNK2001: unresolved external symbol "struct WTFLogChannel WebCore::LogPlugins" (?LogPlugins@WebCore@@3UWTFLogChannel@@A) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\WebKit.dll : fatal error LNK1120: 13 unresolved externals [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] ImageDiff.vcxproj -> C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\ImageDiff.exe
Looks like the Windows bot fixed itself. OK then!
Comment on attachment 321150 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321150&action=review > Tools/DumpRenderTree/PlatformMac.cmake:26 > - WebKit2 > + WebKitLegacy Whoops! WebKit2 shouldn't have become WebKitLegacy.
Yup. I've pushed a fixup for that (r222426).
<rdar://problem/34694101>