Bug 177123 - Cannot put typedefs of templated structs inside structs
Summary: Cannot put typedefs of templated structs inside structs
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Filip Pizlo
Keywords: InRadar
Depends on:
Blocks: 176199
  Show dependency treegraph
Reported: 2017-09-18 21:26 PDT by Myles C. Maxfield
Modified: 2018-10-13 19:36 PDT (History)
3 users (show)

See Also:

the patch (6.82 KB, patch)
2017-09-18 22:07 PDT, Filip Pizlo
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-09-18 21:26:35 PDT
>>> prepare("/internal/test", 0, "struct Foo { int2 x; }")
Exception: Error: Cannot determine if an uninstantiated type is primitive: vec2<int32>
Comment 1 Filip Pizlo 2017-09-18 22:07:25 PDT
Created attachment 321181 [details]
the patch
Comment 2 Michael Saboff 2017-09-19 09:34:46 PDT
Comment on attachment 321181 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321181&action=review


> Tools/ChangeLog:39
> +        type. This chews threw the wrapper and then instantiates the wrapped type, as we want it to.

Change "threw" to "through"
Comment 3 Filip Pizlo 2017-09-19 09:39:53 PDT
Landed in https://trac.webkit.org/changeset/222210/webkit
Comment 4 Radar WebKit Bug Importer 2017-09-27 12:52:45 PDT
Comment 5 Myles C. Maxfield 2018-10-13 19:36:33 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/181