Like: Wrong number of args: int operator+(int, int, int) Type parameters that cannot be inferred: int operator+<T>(int, int) Probably other things.
Created attachment 321503 [details] possible patch It passes tests but I need to write a lot more tests.
Created attachment 321506 [details] more tests Adding tests for the checks I added.
Created attachment 321509 [details] even more tests
Created attachment 321511 [details] more tests!
Created attachment 321514 [details] more tests
Created attachment 321518 [details] more tests
Created attachment 321572 [details] the patch My test hacking spree ended up uncovering some bugs in type instantiation. I then fixed those bugs. Basically, even if we instantiate a Func, we need its CallExpressions to retain the original uninstantiated types for the purpose of reresolving protocol function calls.
Created attachment 321573 [details] the patch
Comment on attachment 321573 [details] the patch Attachment 321573 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4631211 New failing tests: http/tests/cache-storage/cache-representation.https.html
Created attachment 321593 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 321573 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=321573&action=review r=me > Tools/WebGPUShadingLanguageRI/FuncInstantiator.js:97 > + class InstantiationInstantiateImmediates extends InstantiateImmediates { InstantiationInstantiateImmediates 🤔 > Tools/WebGPUShadingLanguageRI/Prepare.js:32 > + parse(standardProgram, "/internal/stdlib", "native", 28 - 1, standardLibrary); What's that number? > Tools/WebGPUShadingLanguageRI/StandardLibrary.js:27 > +// NOTE: The next line is line 28, and we rely on this in Prepare.js. Ah OK.
(In reply to JF Bastien from comment #11) > Comment on attachment 321573 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321573&action=review > > r=me > > > Tools/WebGPUShadingLanguageRI/FuncInstantiator.js:97 > > + class InstantiationInstantiateImmediates extends InstantiateImmediates { > > InstantiationInstantiateImmediates 🤔 > > > Tools/WebGPUShadingLanguageRI/Prepare.js:32 > > + parse(standardProgram, "/internal/stdlib", "native", 28 - 1, standardLibrary); > > What's that number? I'll add a comment. > > > Tools/WebGPUShadingLanguageRI/StandardLibrary.js:27 > > +// NOTE: The next line is line 28, and we rely on this in Prepare.js. > > Ah OK.
Landed in https://trac.webkit.org/changeset/222413/webkit
<rdar://problem/34693367>
Migrated to https://github.com/gpuweb/WHLSL/issues/191