Bug 177089 - Add a section in WSL's documentation about how API objects and WSL interact
Summary: Add a section in WSL's documentation about how API objects and WSL interact
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 176199
  Show dependency treegraph
 
Reported: 2017-09-18 10:47 PDT by Myles C. Maxfield
Modified: 2018-10-13 19:48 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.61 KB, patch)
2017-09-18 10:54 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (7.33 KB, patch)
2017-09-18 11:17 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (7.32 KB, patch)
2017-09-18 13:42 PDT, Myles C. Maxfield
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-09-18 10:47:05 PDT
Add a section in WSL's documentation about how API objects and WSL interact
Comment 1 Myles C. Maxfield 2017-09-18 10:54:24 PDT
Created attachment 321109 [details]
Patch
Comment 2 Myles C. Maxfield 2017-09-18 11:17:13 PDT
Created attachment 321114 [details]
Patch
Comment 3 Filip Pizlo 2017-09-18 11:24:58 PDT
Comment on attachment 321114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321114&action=review

> Tools/WebGPUShadingLanguageRI/WSL.md:402
> +WSL is designed to be useful as both a graphics shading language and as a computation language. However, these two environments have
> +slightly different semantics.
> +
> +When using WSL as a graphics shading language, there is a distinction between *entry-points* and *non-entry-points*. Entry points are
> +top-level functions which have either the `vertex` or `fragment` keyword in front of their declaration. Entry points may not be forward
> +declared. An entry point annotated with the `vertex` keyword may not be used as a fragment shader, and an entry point annotated with the
> +`fragment` keyword may not be used as a vertex shader. No argument of an entry point may be a pointer. Entry points must not accept type arguments (also known as "generics").

For the rest of the document, I was ensuring that paragraphs were all on one text line without wrapping.

I know that's unusual, but it's intentional: the way that wordpress is configured on the webkit.org blog, newlines inside paragraphs will break the paragraph.

Can you format it the way the rest of the document does it, to make it easier to turn this into a webkit.org blog post if we want?
Comment 4 Myles C. Maxfield 2017-09-18 13:42:01 PDT
Created attachment 321125 [details]
Patch
Comment 5 Myles C. Maxfield 2017-09-18 14:04:14 PDT
Committed r222179: <http://trac.webkit.org/changeset/222179>
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:24:51 PDT
<rdar://problem/34693222>
Comment 7 Myles C. Maxfield 2018-10-13 19:48:12 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/192