Bug 177064 - Start working on WSL documentation
Summary: Start working on WSL documentation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks: 176199
  Show dependency treegraph
 
Reported: 2017-09-17 19:29 PDT by Filip Pizlo
Modified: 2018-10-13 16:30 PDT (History)
2 users (show)

See Also:


Attachments
the patch (9.86 KB, patch)
2017-09-17 19:30 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (15.65 KB, patch)
2017-09-17 21:05 PDT, Filip Pizlo
mmaxfield: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-09-17 19:29:35 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2017-09-17 19:30:24 PDT
Created attachment 321066 [details]
the patch
Comment 2 Filip Pizlo 2017-09-17 21:05:27 PDT
Created attachment 321073 [details]
the patch
Comment 3 Filip Pizlo 2017-09-17 22:06:34 PDT
Landed in https://trac.webkit.org/changeset/222140/webkit
Comment 4 Myles C. Maxfield 2017-09-17 22:19:01 PDT
Comment on attachment 321073 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321073&action=review

> Tools/WebGPUShadingLanguageRI/WSL.md:284
> +    int y;

I think you meant double here.
Comment 5 Myles C. Maxfield 2017-09-17 22:24:02 PDT
Comment on attachment 321073 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321073&action=review

> Tools/WebGPUShadingLanguageRI/WSL.md:311
> +- Read-modify-write operators like `+=` are desugared to a load of the load value, the underlying operator (like `+`), and a store of the new value. It's not possible to override `+=`, `-=`, etc.

I think right now it is. We should remove this functionality if this isn't desired.
Comment 6 Myles C. Maxfield 2017-09-18 09:55:43 PDT
"Mylex Maxfield" 😖
Comment 7 Filip Pizlo 2017-09-18 10:42:09 PDT
(In reply to Myles C. Maxfield from comment #6)
> "Mylex Maxfield" 😖

oops!
Comment 8 Radar WebKit Bug Importer 2017-09-27 12:26:25 PDT
<rdar://problem/34693280>
Comment 9 Myles C. Maxfield 2018-10-13 16:30:27 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/124