Bug 177063 – Fill out vector types in WSL's standard library

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Fill out vector types in WSL's standard library

[Myles C. Maxfield]

Created attachment 321063 [details]
Patch

[Myles C. Maxfield]

Created attachment 321065 [details]
Patch

[Filip Pizlo]

Comment on attachment 321065 [details]
Patch

Let’s use generics. You can save a lot of typing by saying that int4/float4/etc are just vec4<isn’t>/etc.

[Myles C. Maxfield]

Created attachment 321075 [details]
Patch

[Filip Pizlo]

Comment on attachment 321075 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321075&action=review

R=me if you add trap, assuming you thread it through everything the obvious way.

> Tools/WebGPUShadingLanguageRI/StandardLibrary.js:141
> +    return null;

How about you add a trap operation, that throws WTrapError the way that we currently do for OOB. 

We should talk about what “trap” means. I think it means that the shader returns prematurely, possibly leaving some output state unpopulated.

[Myles C. Maxfield]

(In reply to Filip Pizlo from comment #5)
> Comment on attachment 321075 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=321075&action=review
> 
> R=me if you add trap, assuming you thread it through everything the obvious
> way.
> 
> > Tools/WebGPUShadingLanguageRI/StandardLibrary.js:141
> > +    return null;
> 
> How about you add a trap operation, that throws WTrapError the way that we
> currently do for OOB. 
> 
> We should talk about what “trap” means. I think it means that the shader
> returns prematurely, possibly leaving some output state unpopulated.

I'll do the trap stuff in a subsequent patch. https://bugs.webkit.org/show_bug.cgi?id=177110

[Myles C. Maxfield]

Committed r222191: <http://trac.webkit.org/changeset/222191>

[Radar WebKit Bug Importer]

<rdar://problem/34693352>

[Myles C. Maxfield]

Migrated to https://github.com/gpuweb/WHLSL/issues/125