Bug 177062 - WSL needs to understand && and ||
Summary: WSL needs to understand && and ||
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 176199
  Show dependency treegraph
 
Reported: 2017-09-17 18:29 PDT by Myles C. Maxfield
Modified: 2018-10-13 16:32 PDT (History)
5 users (show)

See Also:


Attachments
Patch (15.38 KB, patch)
2017-09-17 18:30 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-09-17 18:29:02 PDT
WSL needs to understand && and ||
Comment 1 Myles C. Maxfield 2017-09-17 18:30:10 PDT
Created attachment 321060 [details]
Patch
Comment 2 Filip Pizlo 2017-09-17 20:00:28 PDT
Comment on attachment 321060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321060&action=review

> Tools/WebGPUShadingLanguageRI/Evaluator.js:175
> +        case "&&":

Nice. I like that you’re just using the operator itself.
Comment 3 WebKit Commit Bot 2017-09-17 20:39:23 PDT
Comment on attachment 321060 [details]
Patch

Clearing flags on attachment: 321060

Committed r222139: <http://trac.webkit.org/changeset/222139>
Comment 4 WebKit Commit Bot 2017-09-17 20:39:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:29:29 PDT
<rdar://problem/34693373>
Comment 6 Myles C. Maxfield 2018-10-13 16:32:34 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/126