It's the latest stable version and we can get rid of the patches we have.
Created attachment 320894 [details] Patch I've also removed the osx patch, because I'm not happy patching fontconfig (unless it's really needed). If it's still needed someone involved in macos should propose a new patch and explain what it does and why it's needed.
Created attachment 320895 [details] Patch Fix the version number in the ChangeLog, it's 2.12.4.
Comment on attachment 320895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320895&action=review > Tools/ChangeLog:16 > + * gtk/patches/fontconfig-fix-osx-cache.diff: Removed. Philippe added this patch in bug #150799. I would either keep it, or ask him before removing it.
(In reply to Michael Catanzaro from comment #3) > Comment on attachment 320895 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=320895&action=review > > > Tools/ChangeLog:16 > > + * gtk/patches/fontconfig-fix-osx-cache.diff: Removed. > > Philippe added this patch in bug #150799. I would either keep it, or ask him > before removing it. It's not needed for tests, so it can be added in a follow up in any case. I think we should set a more restrictive policy to patch deps in jhbuild. But meanwhile, it's better to remove patches we don't need than keeping them, not the other way around.
Comment on attachment 320895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320895&action=review >>> Tools/ChangeLog:16 >>> + * gtk/patches/fontconfig-fix-osx-cache.diff: Removed. >> >> Philippe added this patch in bug #150799. I would either keep it, or ask him before removing it. > > It's not needed for tests, so it can be added in a follow up in any case. I think we should set a more restrictive policy to patch deps in jhbuild. But meanwhile, it's better to remove patches we don't need than keeping them, not the other way around. I agree with Carlos. The most recent Fontconfig releases might even have fixed this bug anyway.
Committed r222128: <http://trac.webkit.org/changeset/222128>