Bug 150799 - [Mac][GTK] Jhbuild support for OSX
Summary: [Mac][GTK] Jhbuild support for OSX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
Depends on:
Blocks: 126492
  Show dependency treegraph
Reported: 2015-11-02 06:27 PST by Philippe Normand
Modified: 2015-12-30 00:34 PST (History)
3 users (show)

See Also:

Patch (16.85 KB, patch)
2015-11-02 06:34 PST, Philippe Normand
no flags Details | Formatted Diff | Diff
updated patch (18.33 KB, patch)
2015-12-05 07:52 PST, Philippe Normand
no flags Details | Formatted Diff | Diff
same patch (18.33 KB, patch)
2015-12-07 02:08 PST, Philippe Normand
no flags Details | Formatted Diff | Diff
updated patch (16.29 KB, patch)
2015-12-08 02:28 PST, Philippe Normand
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2015-11-02 06:27:02 PST
Some modules depend on X11 so let's disable them on OSX. If we want to run layout tests on that platform, something will need to be figured out to not depend on Xvfb though.
Comment 1 Philippe Normand 2015-11-02 06:34:42 PST
Created attachment 264582 [details]
Comment 2 Michael Catanzaro 2015-11-02 07:23:46 PST
I'd like to see two improvements here:

* Instead of splitting the OS X and Linux dependencies into separate modulesets, I'd like to have just the one moduleset with platform conditionals instead.

* Instead of using module_autogenargs and module_makeargs in the jhbuildrc file (intended to be used for user-specific configuration, not configuration necessary to make the modules build at all), the autogenargs and makeargs should be specified in the modulesets file.

Example: https://git.gnome.org/browse/jhbuild/tree/modulesets/gnome-suites-core-deps-3.20.modules#n425

Documentation: " https://developer.gnome.org/jhbuild/unstable/moduleset-syntax.html.en

You might need to upgrade the jhbuild version to get conditionals; see bug #145697 for an example.
Comment 3 Philippe Normand 2015-11-02 07:26:30 PST
Ah, I had no idea about this feature :) I'll rework the patch, thanks for the suggestions, Michael!
Comment 4 Philip Chimento 2015-11-02 09:04:10 PST
Comment on attachment 264582 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=264582&action=review

> Tools/gtk/jhbuild.modules:-249
> -             autogenargs="--disable-introspection">

--disable-introspection and --enable-introspection=no should be just the same, right?
Comment 5 Philippe Normand 2015-11-06 04:38:52 PST
Seems like this doesn't work for makeargs tuning :/
Comment 6 Philippe Normand 2015-12-05 07:52:50 PST
Created attachment 266715 [details]
updated patch
Comment 7 Philippe Normand 2015-12-07 02:08:23 PST
Created attachment 266757 [details]
same patch

For EWS.
Comment 8 Philippe Normand 2015-12-08 02:28:08 PST
Created attachment 266868 [details]
updated patch
Comment 9 Michael Catanzaro 2015-12-22 07:00:11 PST
Comment on attachment 266868 [details]
updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266868&action=review

> Tools/gtk/jhbuild.modules:75
> +  <autotools id="cairo" makeargs="">

Do you need the makeargs=""? I think that is for appending, not overriding, so I guess it does nothing.
Comment 10 Philippe Normand 2015-12-30 00:34:07 PST
Committed r194444: <http://trac.webkit.org/changeset/194444>