Some modules depend on X11 so let's disable them on OSX. If we want to run layout tests on that platform, something will need to be figured out to not depend on Xvfb though.
Created attachment 264582 [details] Patch
I'd like to see two improvements here: * Instead of splitting the OS X and Linux dependencies into separate modulesets, I'd like to have just the one moduleset with platform conditionals instead. * Instead of using module_autogenargs and module_makeargs in the jhbuildrc file (intended to be used for user-specific configuration, not configuration necessary to make the modules build at all), the autogenargs and makeargs should be specified in the modulesets file. Example: https://git.gnome.org/browse/jhbuild/tree/modulesets/gnome-suites-core-deps-3.20.modules#n425 Documentation: " https://developer.gnome.org/jhbuild/unstable/moduleset-syntax.html.en You might need to upgrade the jhbuild version to get conditionals; see bug #145697 for an example.
Ah, I had no idea about this feature :) I'll rework the patch, thanks for the suggestions, Michael!
Comment on attachment 264582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264582&action=review > Tools/gtk/jhbuild.modules:-249 > - autogenargs="--disable-introspection"> --disable-introspection and --enable-introspection=no should be just the same, right?
Seems like this doesn't work for makeargs tuning :/
Created attachment 266715 [details] updated patch
Created attachment 266757 [details] same patch For EWS.
Created attachment 266868 [details] updated patch
Comment on attachment 266868 [details] updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=266868&action=review > Tools/gtk/jhbuild.modules:75 > + <autotools id="cairo" makeargs=""> Do you need the makeargs=""? I think that is for appending, not overriding, so I guess it does nothing.
Committed r194444: <http://trac.webkit.org/changeset/194444>