Bug 176986 – iOS: Use blob URL instead of a WebKit fake URL when pasting an image

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

https://trac.webkit.org/changeset/208451 fixed the bug that we were using a fake WebKit URL
and not allowing authors to read the actual image content but not for iOS.

Fix this problem for iOS.

[Radar WebKit Bug Importer]

<rdar://problem/34455052>

[Ryosuke Niwa]

Created attachment 320876 [details]
Fixes the bug

[Ryosuke Niwa]

Created attachment 320883 [details]
Fixed builds

[Alexey Proskuryakov]

Comment on attachment 320883 [details]
Fixed builds

View in context: https://bugs.webkit.org/attachment.cgi?id=320883&action=review

> Source/WebCore/ChangeLog:30
> +        (WebCore::URL::fakeURLWithRelativePart): Deleted.

Have you got rid of all uses of fake url? There used to be some in WebKit{Legacy}, which should use this function instead of duplicating code.

[Ryosuke Niwa]

(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 320883 [details]
> Fixed builds
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320883&action=review
> 
> > Source/WebCore/ChangeLog:30
> > +        (WebCore::URL::fakeURLWithRelativePart): Deleted.
> 
> Have you got rid of all uses of fake url? There used to be some in
> WebKit{Legacy}, which should use this function instead of duplicating code.

Oh, interesting, we're exposing it as [NSURL uniqueURLWithRelativePart]. See WebNSURLExtras.mm and WebHTMLView.mm.

I don't think we should keep this function in WebCore because all uses of fake URL in WebCore breaks things. We can consolidate the definition of fake URLs in WebKitLegacy into one place instead.

[Ryosuke Niwa]

It looks like the only use of this that fake URL on iOS (_documentFragmentForImageData) is no longer used. So we can probably get rid of it altogether as well.

On Mac, _web_documentFragmentFromPasteboard is used by _documentFragmentFromPasteboard and that still has some use outside WebKit.

So we can probably make this fake URL thing Mac only, and remove it in near future.

[Ryosuke Niwa]

Note I'm going to do WebKitLegacy code change in a separate patch since that's somewhat orthogonal to what this patch tries to do, which is a bug fix in iOS.

[Ryosuke Niwa]

Oh never mind. Just saw your patch on https://bugs.webkit.org/show_bug.cgi?id=176123. I guess we have to keep fakeURLWithRelativePart for the time being :(

[Ryosuke Niwa]

Created attachment 320957 [details]
Don't remove fakeURLWithRelativePart

[WebKit Commit Bot]

Comment on attachment 320957 [details]
Don't remove fakeURLWithRelativePart

Clearing flags on attachment: 320957

Committed r222119: <http://trac.webkit.org/changeset/222119>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.