RESOLVED FIXED 176821
Remove CanvasRenderingContext2D.commit(), it is a no-op and not part the standard 
https://bugs.webkit.org/show_bug.cgi?id=176821
Summary Remove CanvasRenderingContext2D.commit(), it is a no-op and not part the stan...
Sam Weinig
Reported 2017-09-12 17:57:54 PDT
Remove CanvasRenderingContext2D.commit(), it is a no-op and not part the standard
Attachments
Patch (59.93 KB, patch)
2017-09-12 18:01 PDT, Sam Weinig 		darin: review+
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.70 MB, application/zip)
2017-09-12 19:17 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews103 for mac-elcapitan (1.32 MB, application/zip)
2017-09-12 19:19 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.28 MB, application/zip)
2017-09-12 19:35 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews117 for mac-elcapitan (2.12 MB, application/zip)
2017-09-12 19:35 PDT, Build Bot 		no flags
Details
Patch (61.66 KB, patch)
2017-09-13 02:42 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-09-12 18:01:22 PDT
Created attachment 320591 [details] Patch
Build Bot
Comment 2 2017-09-12 19:17:38 PDT
Comment on attachment 320591 [details] Patch Attachment 320591 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4529471 New failing tests: fast/canvas/commit.html
Build Bot
Comment 3 2017-09-12 19:17:40 PDT
Created attachment 320602 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 4 2017-09-12 19:19:09 PDT
Comment on attachment 320591 [details] Patch Attachment 320591 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4529488 New failing tests: fast/canvas/commit.html
Build Bot
Comment 5 2017-09-12 19:19:11 PDT
Created attachment 320603 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 6 2017-09-12 19:35:28 PDT
Comment on attachment 320591 [details] Patch Attachment 320591 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4529470 New failing tests: fast/canvas/commit.html
Build Bot
Comment 7 2017-09-12 19:35:29 PDT
Created attachment 320606 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Build Bot
Comment 8 2017-09-12 19:35:56 PDT
Comment on attachment 320591 [details] Patch Attachment 320591 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4529468 New failing tests: fast/canvas/commit.html
Build Bot
Comment 9 2017-09-12 19:35:57 PDT
Created attachment 320607 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Sam Weinig
Comment 10 2017-09-13 02:42:36 PDT
Created attachment 320628 [details] Patch
Sam Weinig
Comment 11 2017-09-13 08:31:17 PDT
Committed r221969: <http://trac.webkit.org/changeset/221969>
Sam Weinig
Comment 12 2017-09-21 13:58:35 PDT
*** Bug 176343 has been marked as a duplicate of this bug. ***
Radar WebKit Bug Importer
Comment 13 2017-09-27 12:31:23 PDT
<rdar://problem/34693422>
Note You need to log in before you can comment on or make changes to this bug.