Bug 176699 – Older versions should adopt newer version's expectations on mac

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

In https://bugs.webkit.org/show_bug.cgi?id=174472, test expectation inheritance for Mac was modified so it was more in-line with other platforms.  There was an aspect of this test inheritance, however, which should be retained to make incrementing versions easier.  Consider El Capitan as we transition to High Sierra:

If test expectation inheritance looks like this for El Capitan:

mac-add-elcapitan-wk2 => mac-elcapitan => mac-sierra-wk2 => mac-sierra => mac-wk2 => mac => wk2

Then we can move any Sierra/El Capitan expectations into mac-sierra, and general High Sierra expectations into Mac (since such expectations will likely apply to future operating systems as well).  Before r219507, this was the technique used.  However, general mac overrode version specific expectations before r219507 (which is definitely incorrect).  See the ChangeLog of <https://trac.webkit.org/changeset/219507/webkit> for details.

[Radar WebKit Bug Importer]

<rdar://problem/34367907>

[Jonathan Bedard]

Created attachment 320432 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 320432 [details]
Patch

Rejecting attachment 320432 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 320432, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 221872 = 8af2268a70bf54353a9d2d586ef20842d13588ca
r221873 = 52fffebf9340ce45308b469d58249c4e9c41a60d
r221874 = 3e36c33d1a9fd59bc8f66681346174d194164729
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/4515570

[Jonathan Bedard]

Committed r221877: <http://trac.webkit.org/changeset/221877>