Bug 176463 - Move test expectations from 'mac-highsierra' to 'mac' directory
Summary: Move test expectations from 'mac-highsierra' to 'mac' directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Haddad
URL:
Keywords: InRadar
Depends on: 176699
Blocks:
  Show dependency tree / graph
 
Reported: 2017-09-06 09:23 PDT by Ryan Haddad
Modified: 2017-09-27 13:08 PDT (History)
6 users (show)

See Also:

Attachments
Patch (14.69 MB, patch)
2017-09-06 14:54 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
Patch (16.12 MB, patch)
2017-09-07 10:04 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
Patch (14.70 MB, patch)
2017-09-14 15:35 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
Patch (14.72 MB, patch)
2017-09-14 17:00 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
Patch for landing (14.72 MB, patch)
2017-09-15 09:28 PDT, Ryan Haddad 		ryanhaddad: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-09-06 09:23:00 PDT 
Move test expectations from 'mac-highsierra' to 'mac' directory
Comment 1 Ryan Haddad 2017-09-06 14:54:24 PDT 
Created attachment 320063 [details]
Patch

Patch for EWS
Comment 2 Build Bot 2017-09-06 15:05:59 PDT 
Attachment 320063 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 237 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ryan Haddad 2017-09-07 10:04:57 PDT 
Created attachment 320123 [details]
Patch
Comment 4 Build Bot 2017-09-07 10:20:10 PDT 
Attachment 320123 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:8:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 303 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Ryan Haddad 2017-09-14 15:35:41 PDT 
Created attachment 320834 [details]
Patch
Comment 6 Build Bot 2017-09-14 15:49:06 PDT 
Attachment 320834 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:8:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 239 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Ryan Haddad 2017-09-14 17:00:17 PDT 
Created attachment 320846 [details]
Patch
Comment 8 Build Bot 2017-09-14 17:11:55 PDT 
Attachment 320846 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:8:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 248 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Ryan Haddad 2017-09-14 18:34:15 PDT 
Finally all green :)
Comment 10 Ryan Haddad 2017-09-15 09:28:18 PDT 
Created attachment 320910 [details]
Patch for landing
Comment 11 Ryan Haddad 2017-09-15 14:21:06 PDT 
Landed in <https://trac.webkit.org/changeset/222111>
Comment 12 Ryan Haddad 2017-09-15 16:46:44 PDT 
Additional gardening for Sierra in <https://trac.webkit.org/r222117>
Comment 13 Radar WebKit Bug Importer 2017-09-27 13:08:34 PDT 
<rdar://problem/34694687>