Bug 176677 - WSL Substitution should probably wrap type variables of substituted types rather than just wrapping the whole type
Summary: WSL Substitution should probably wrap type variables of substituted types rat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
: 176678 (view as bug list)
Depends on:
Blocks: 176199
  Show dependency treegraph
 
Reported: 2017-09-10 15:35 PDT by Filip Pizlo
Modified: 2018-10-13 16:50 PDT (History)
2 users (show)

See Also:


Attachments
the patch (20.28 KB, patch)
2017-09-11 11:46 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (22.04 KB, patch)
2017-09-11 12:19 PDT, Filip Pizlo
mmaxfield: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-09-10 15:35:25 PDT
...
Comment 1 Filip Pizlo 2017-09-10 15:39:06 PDT
I think that Substitution should do something akin to CheckWrapped, but instead of throwing errors, it should just wrap the bad thing.
Comment 2 Filip Pizlo 2017-09-11 11:44:05 PDT
*** Bug 176678 has been marked as a duplicate of this bug. ***
Comment 3 Filip Pizlo 2017-09-11 11:46:10 PDT
Created attachment 320449 [details]
the patch
Comment 4 Filip Pizlo 2017-09-11 12:19:07 PDT
Created attachment 320454 [details]
the patch
Comment 5 Filip Pizlo 2017-09-11 14:20:23 PDT
Comment on attachment 320454 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320454&action=review

> Tools/WebGPUShadingLanguageRI/AutoWrapper.js:45
> +        return TypeRef.wrap(node);

This should be VariableRef.wrap
Comment 6 Myles C. Maxfield 2017-09-11 15:41:13 PDT
Comment on attachment 320454 [details]
the patch

Looks good.
Comment 7 Filip Pizlo 2017-09-11 16:00:18 PDT
Landed in https://trac.webkit.org/changeset/221888/webkit
Comment 8 Radar WebKit Bug Importer 2017-09-27 13:01:34 PDT
<rdar://problem/34694498>
Comment 9 Myles C. Maxfield 2018-10-13 16:50:42 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/143