Bug 176585 - Use RenderLayerBacking::renderer() when possible
Summary: Use RenderLayerBacking::renderer() when possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on:
Blocks: 176261
  Show dependency treegraph
 
Reported: 2017-09-07 23:44 PDT by Frédéric Wang (:fredw)
Modified: 2017-09-27 12:41 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.83 KB, patch)
2017-09-07 23:49 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch for landing (28.01 KB, patch)
2017-09-08 00:54 PDT, Frédéric Wang (:fredw)
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch (2.83 KB, patch)
2017-09-08 01:57 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2017-09-07 23:44:17 PDT
Small cleanup extracted from bug 176261. The private member renderer() is a shorthand for m_owningLayer.renderer() and can be used in various places of RenderLayerBacking.
Comment 1 Frédéric Wang (:fredw) 2017-09-07 23:49:59 PDT
Created attachment 320245 [details]
Patch
Comment 2 WebKit Commit Bot 2017-09-08 00:34:30 PDT
Comment on attachment 320245 [details]
Patch

Rejecting attachment 320245 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 320245, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ing rebase:
:040000 040000 a71b4b74fa71caf5ee40505222e4ece8ea1c41c9 5f584218e40d75a9c39c52b76fd648459857f264 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/4484804
Comment 3 WebKit Commit Bot 2017-09-08 00:48:54 PDT
Comment on attachment 320245 [details]
Patch

Rejecting attachment 320245 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 320245, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ing rebase:
:040000 040000 a71b4b74fa71caf5ee40505222e4ece8ea1c41c9 5f584218e40d75a9c39c52b76fd648459857f264 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/4484869
Comment 4 Frédéric Wang (:fredw) 2017-09-08 00:54:35 PDT
Created attachment 320248 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-09-08 01:35:49 PDT
Comment on attachment 320248 [details]
Patch for landing

Rejecting attachment 320248 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 320248, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
264 M	Source
:040000 040000 0855c73d1c70bced231228fcd6fbcf4c25fbc927 7faa3cb8917a0bdbd9d0d34942b8d5422ee72eb9 M	Tools
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/4485186
Comment 6 Frédéric Wang (:fredw) 2017-09-08 01:57:22 PDT
Created attachment 320252 [details]
Patch
Comment 7 WebKit Commit Bot 2017-09-09 02:35:36 PDT
Comment on attachment 320252 [details]
Patch

Clearing flags on attachment: 320252

Committed r221813: <http://trac.webkit.org/changeset/221813>
Comment 8 WebKit Commit Bot 2017-09-09 02:35:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-09-27 12:41:28 PDT
<rdar://problem/34693764>