Bug 176581 – WSL should support while loops

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

WSL should support while loops

[Myles C. Maxfield]

Created attachment 320230 [details]
WIP

[Myles C. Maxfield]

Created attachment 320246 [details]
WIP

[Myles C. Maxfield]

Comment on attachment 320246 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=320246&action=review

> Tools/WebGPUShadingLanguageRI/Node.js:40
> +        //memoTable.set(this, returnValue);

Because Evaluator is a Visitor, the memo table doesn't work when evaluating, because while loops' conditions need to actually be evaluated each time. Fil: Do you know a way to solve this?

[Myles C. Maxfield]

Created attachment 320285 [details]
WIP

[Myles C. Maxfield]

Created attachment 320406 [details]
Patch

[Myles C. Maxfield]

Created attachment 320408 [details]
Patch

[Myles C. Maxfield]

Created attachment 320409 [details]
Patch

[Filip Pizlo]

Comment on attachment 320409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320409&action=review

Nice!  R=me.

> Tools/WebGPUShadingLanguageRI/Break.js:38
> +        return "Break";

Lowercase is better since that’s what te language does.

> Tools/WebGPUShadingLanguageRI/Checker.js:245
> +            throw new Error("Trying to negate something with no type: " + node.conditional);

I don’t think negation is what is going on here.

[Myles C. Maxfield]

Committed r221842: <http://trac.webkit.org/changeset/221842>

[Myles C. Maxfield]

*** Bug 176263 has been marked as a duplicate of this bug. ***

[Radar WebKit Bug Importer]

<rdar://problem/34693608>

[Myles C. Maxfield]

Migrated to https://github.com/gpuweb/WHLSL/issues/146