Bug 176440 - WSL: Inliner doesn't allow double-negation
Summary: WSL: Inliner doesn't allow double-negation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks: 176199
  Show dependency tree / graph
 
Reported: 2017-09-05 22:23 PDT by Myles C. Maxfield
Modified: 2018-10-13 16:58 PDT (History)
3 users (show)

See Also:

Attachments
the patch (6.80 KB, patch)
2017-09-06 11:34 PDT, Filip Pizlo 		mmaxfield: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-09-05 22:23:08 PDT 
doPrep() fails with "bool foo(bool x) { return !!x; }"
Comment 1 Filip Pizlo 2017-09-06 11:34:47 PDT 
Created attachment 320043 [details]
the patch
Comment 2 Myles C. Maxfield 2017-09-06 11:53:06 PDT 
Comment on attachment 320043 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320043&action=review

> Tools/WebGPUShadingLanguageRI/Parse.js:-649
> -            result.origin = operatorToken.origin;

Thanks

> Tools/WebGPUShadingLanguageRI/VisitingSet.js:36
> +            print("item: " + item + " (" + item.constructor.name + ")");

Print
Comment 3 Filip Pizlo 2017-09-06 13:04:17 PDT 
Landed in https://trac.webkit.org/changeset/221692/webkit
Comment 4 Radar WebKit Bug Importer 2017-09-27 12:35:16 PDT 
<rdar://problem/34693538>
Comment 5 Myles C. Maxfield 2018-10-13 16:58:06 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/150