Bug 176334 – [WSL] Rationalize how protocol inheritance deals with type parameters

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Filip Pizlo]

If a signature in a protocol has type parameters, then we should probably pass those type parameters as type arguments during inheritance resolution.

[Filip Pizlo]

Created attachment 320127 [details]
the patch

[Filip Pizlo]

Created attachment 320130 [details]
the patch

[Mark Lam]

Comment on attachment 320130 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320130&action=review

r=me

> Tools/WebGPUShadingLanguageRI/ProtocolDecl.js:93
> +            let overload = this.program.resolveFuncOverload(signature.name, signature.typeParameters, signature.parameterTypes);

Not really due to this patch but "typeParameters" and "parameterTypes" sound too similar.  Can there be better names for these?

[Filip Pizlo]

(In reply to Mark Lam from comment #3)
> Comment on attachment 320130 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320130&action=review
> 
> r=me
> 
> > Tools/WebGPUShadingLanguageRI/ProtocolDecl.js:93
> > +            let overload = this.program.resolveFuncOverload(signature.name, signature.typeParameters, signature.parameterTypes);
> 
> Not really due to this patch but "typeParameters" and "parameterTypes" sound
> too similar.  Can there be better names for these?

They are indeed confusing.  But, they are terms of art.

[Filip Pizlo]

Landed in https://trac.webkit.org/changeset/221740/webkit

[Radar WebKit Bug Importer]

<rdar://problem/34693637>

[Myles C. Maxfield]

Migrated to https://github.com/gpuweb/WHLSL/issues/152