Bug 176290 - WSL should support structs
Summary: WSL should support structs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks: 176199
  Show dependency tree / graph
 
Reported: 2017-09-02 20:44 PDT by Filip Pizlo
Modified: 2018-10-13 17:05 PDT (History)
2 users (show)

See Also:

Attachments
the patch (41.64 KB, patch)
2017-09-02 20:48 PDT, Filip Pizlo 		mmaxfield: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-09-02 20:44:19 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2017-09-02 20:48:24 PDT 
Created attachment 319756 [details]
the patch
Comment 2 Filip Pizlo 2017-09-02 21:18:05 PDT 
Comment on attachment 319756 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319756&action=review

> Tools/WebGPUShadingLanguageRI/FuncInstantiator.js:99
> -        let resultingFunc = func.visit(new Instantiate());
> +        
> +        let resultingFunc = func.visit(new Instantiate(substitution));

I'll revert.

> Tools/WebGPUShadingLanguageRI/InstantiateImmediates.js:44
> +    
> +    visitVariableDecl(node)
> +    {
> +        let result = super.visitVariableDecl(node);
> +        return result;
> +    }

I will remove.
Comment 3 Filip Pizlo 2017-09-03 10:48:12 PDT 
Landed in https://trac.webkit.org/changeset/221550/webkit
Comment 4 Radar WebKit Bug Importer 2017-09-27 12:55:25 PDT 
<rdar://problem/34694277>
Comment 5 Myles C. Maxfield 2018-10-13 17:05:36 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/157