Bug 176208 - WSL Rewriter should be an identity on things that aren't inside function bodies
Summary: WSL Rewriter should be an identity on things that aren't inside function bodies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks: 176199
  Show dependency treegraph
 
Reported: 2017-08-31 19:35 PDT by Filip Pizlo
Modified: 2018-10-13 19:57 PDT (History)
2 users (show)

See Also:


Attachments
the patch (6.42 KB, patch)
2017-09-01 11:22 PDT, Filip Pizlo
mmaxfield: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-08-31 19:35:28 PDT
That way, if we ever short-circuit a TypeRef, it'll be OK.  And Rewriter will be able to rewrite TypeRef.type.
Comment 1 Filip Pizlo 2017-09-01 11:22:32 PDT
Created attachment 319623 [details]
the patch
Comment 2 Filip Pizlo 2017-09-01 11:49:08 PDT
Landed in https://trac.webkit.org/changeset/221487/webkit
Comment 3 Radar WebKit Bug Importer 2017-09-27 12:42:12 PDT
<rdar://problem/34693792>
Comment 4 Myles C. Maxfield 2018-10-13 19:57:42 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/201