WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
176203
Add WKUIDelegatePrivate equivalent of WKPageUIClient's isPlayingAudioDidChange
https://bugs.webkit.org/show_bug.cgi?id=176203
Summary
Add WKUIDelegatePrivate equivalent of WKPageUIClient's isPlayingAudioDidChange
Alex Christensen
Reported
2017-08-31 17:25:58 PDT
Add WKUIDelegatePrivate equivalent of WKPageUIClient's isPlayingAudioDidChange
Attachments
Patch
(10.37 KB, patch)
2017-08-31 17:26 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(10.35 KB, patch)
2017-08-31 17:50 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(10.34 KB, patch)
2017-08-31 17:51 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2017-08-31 17:26:32 PDT
Created
attachment 319549
[details]
Patch
Tim Horton
Comment 2
2017-08-31 17:35:47 PDT
Comment on
attachment 319549
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=319549&action=review
> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:121 > + [webView loadRequest:[NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"file-with-video" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]]];
I think there's a nicer way to write this but I don't remember what it is. Check out TestWKWebView.
> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:123 > + [webView evaluateJavaScript:@"playVideo()" completionHandler:^(id, NSError *) { }];
This can definitely be nil.
Alex Christensen
Comment 3
2017-08-31 17:50:09 PDT
Created
attachment 319556
[details]
Patch
Build Bot
Comment 4
2017-08-31 17:51:32 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See
http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alex Christensen
Comment 5
2017-08-31 17:51:40 PDT
Created
attachment 319557
[details]
Patch
Alex Christensen
Comment 6
2017-08-31 18:47:45 PDT
http://trac.webkit.org/r221466
mitz
Comment 7
2017-08-31 19:07:35 PDT
Why not add an observable property instead?
Alex Christensen
Comment 8
2017-08-31 22:57:31 PDT
Dan, mostly because I didn't know how, but now I do! See
https://bugs.webkit.org/show_bug.cgi?id=176212
mitz
Comment 9
2017-08-31 22:58:54 PDT
(In reply to Alex Christensen from
comment #8
)
> Dan, mostly because I didn't know how, but now I do! > See
https://bugs.webkit.org/show_bug.cgi?id=176212
Cool!
Radar WebKit Bug Importer
Comment 10
2017-09-27 12:52:06 PDT
<
rdar://problem/34694171
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug