176212 – Replace WKUIDelegatePrivate's isPlayingMediaDidChange with KVO _isPlayingAudio on WKWebView

Bug 176212 - Replace WKUIDelegatePrivate's isPlayingMediaDidChange with KVO _isPlayingAudio on WKWebView

Summary: Replace WKUIDelegatePrivate's isPlayingMediaDidChange with KVO _isPlayingAudi...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Alex Christensen

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2017-08-31 22:53 PDT by Alex Christensen
Modified:	2017-09-27 12:55 PDT (History)
CC List:	7 users (show)

See Also:

Attachments
Patch (19.45 KB, patch) 2017-08-31 22:56 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (24.60 KB, patch) 2017-09-01 09:12 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (24.74 KB, patch) 2017-09-01 09:49 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (25.33 KB, patch) 2017-09-01 10:45 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (25.54 KB, patch) 2017-09-01 11:03 PDT, Alex Christensen	thorton: review+	Details \| Formatted Diff \| Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alex Christensen 2017-08-31 22:53:38 PDT

Replace WKUIDelegatePrivate's isPlayingMediaDidChange with KVO _isPlayingAudio on WKWebView

Comment 1 Alex Christensen 2017-08-31 22:56:41 PDT

Created attachment 319578 [details]
Patch

Comment 2 Build Bot 2017-08-31 22:58:37 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 Alex Christensen 2017-09-01 09:12:21 PDT

Created attachment 319599 [details]
Patch

Comment 4 Alex Christensen 2017-09-01 09:49:29 PDT

Created attachment 319604 [details]
Patch

Comment 5 Alex Christensen 2017-09-01 10:45:45 PDT

Created attachment 319613 [details]
Patch

Comment 6 Alex Christensen 2017-09-01 11:03:47 PDT

Created attachment 319621 [details]
Patch

Comment 7 Alex Christensen 2017-09-01 11:55:06 PDT

http://trac.webkit.org/r221489

Comment 8 Radar WebKit Bug Importer 2017-09-27 12:55:45 PDT

<rdar://problem/34694290>