Bug 176197 - WSL should support makeptr (\)
Summary: WSL should support makeptr (\)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks: 176199
  Show dependency treegraph
 
Reported: 2017-08-31 17:03 PDT by Filip Pizlo
Modified: 2018-10-13 19:59 PDT (History)
3 users (show)

See Also:


Attachments
the patch (22.06 KB, patch)
2017-08-31 17:05 PDT, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-08-31 17:03:20 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2017-08-31 17:05:42 PDT
Created attachment 319543 [details]
the patch
Comment 2 Saam Barati 2017-08-31 17:07:43 PDT
Comment on attachment 319543 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319543&action=review

> Tools/WebGPUShadingLanguageRI/Evaluator.js:132
> +                throw new Error("Cannot get type or argument; i = " + i + ", argument = " + argument + ", type = " + type + "; in " + node);

if you use a template literal here I'd think it'd be easier to read.
Comment 3 Filip Pizlo 2017-08-31 17:09:58 PDT
Landed in https://trac.webkit.org/changeset/221460/webkit
Comment 4 Radar WebKit Bug Importer 2017-09-27 12:47:41 PDT
<rdar://problem/34694027>
Comment 5 Myles C. Maxfield 2018-10-13 19:59:49 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/203