Bug 176177 - WSL parser should pass the token as the origin to the AST
Summary: WSL parser should pass the token as the origin to the AST
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Keywords: InRadar
Depends on:
Blocks: 176199
  Show dependency treegraph
Reported: 2017-08-31 12:42 PDT by Filip Pizlo
Modified: 2018-10-13 20:06 PDT (History)
3 users (show)

See Also:

the patch (13.90 KB, patch)
2017-08-31 12:44 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (13.53 KB, patch)
2017-08-31 12:46 PDT, Filip Pizlo
keith_miller: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-08-31 12:42:41 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2017-08-31 12:44:57 PDT
Created attachment 319503 [details]
the patch
Comment 2 Filip Pizlo 2017-08-31 12:46:26 PDT
Created attachment 319504 [details]
the patch
Comment 3 Keith Miller 2017-08-31 12:48:45 PDT
Comment on attachment 319504 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319504&action=review

r=me with nit.

> Tools/WebGPUShadingLanguageRI/Test.js:67
> +        () => prepare("<test>", 0, "int foo(int x) { return x + y; }"),

Nit: Seems like you might want to make a wrapper for prepare in this file. I expect you'll be calling it a lot...
Comment 4 Filip Pizlo 2017-08-31 12:52:19 PDT
Landed in https://trac.webkit.org/changeset/221436/webkit
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:59:01 PDT
Comment 6 Myles C. Maxfield 2018-10-13 20:06:08 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/209