Bug 176171 - Make RenderStyle's non-inherited flags more human friendly
Summary: Make RenderStyle's non-inherited flags more human friendly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks: 176210
  Show dependency treegraph
 
Reported: 2017-08-31 10:34 PDT by Daniel Bates
Modified: 2017-09-27 12:43 PDT (History)
7 users (show)

See Also:


Attachments
Patch (48.56 KB, patch)
2017-08-31 10:42 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (547.61 KB, application/zip)
2017-08-31 11:20 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (566.54 KB, application/zip)
2017-08-31 11:23 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews114 for mac-elcapitan (266.06 KB, application/zip)
2017-08-31 11:40 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (322.91 KB, application/zip)
2017-08-31 11:59 PDT, Build Bot
no flags Details
Patch (53.70 KB, patch)
2017-08-31 15:25 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (53.83 KB, patch)
2017-08-31 15:27 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Another patch to fix the wincairo build (1.85 KB, patch)
2017-08-31 21:07 PDT, Yoshiaki Jitsukawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-08-31 10:34:06 PDT
Revert the change made in bug #130939 to make RenderStyle's non-inherited flags more JSC friendly as we never followed through to have the CSS JIT update RenderStyle directly.
Comment 1 Daniel Bates 2017-08-31 10:42:09 PDT
Created attachment 319478 [details]
Patch
Comment 2 Build Bot 2017-08-31 11:20:02 PDT Comment hidden (obsolete)
Comment 3 Build Bot 2017-08-31 11:20:04 PDT Comment hidden (obsolete)
Comment 4 Build Bot 2017-08-31 11:23:41 PDT Comment hidden (obsolete)
Comment 5 Build Bot 2017-08-31 11:23:42 PDT Comment hidden (obsolete)
Comment 6 Build Bot 2017-08-31 11:40:18 PDT Comment hidden (obsolete)
Comment 7 Build Bot 2017-08-31 11:40:20 PDT Comment hidden (obsolete)
Comment 8 Build Bot 2017-08-31 11:59:21 PDT Comment hidden (obsolete)
Comment 9 Build Bot 2017-08-31 11:59:22 PDT Comment hidden (obsolete)
Comment 10 Daniel Bates 2017-08-31 15:25:54 PDT
Created attachment 319529 [details]
Patch
Comment 11 Daniel Bates 2017-08-31 15:27:30 PDT
Created attachment 319530 [details]
Patch
Comment 12 Daniel Bates 2017-08-31 16:55:16 PDT
Comment on attachment 319530 [details]
Patch

Clearing flags on attachment: 319530

Committed r221459: <http://trac.webkit.org/changeset/221459>
Comment 13 Daniel Bates 2017-08-31 16:55:18 PDT
All reviewed patches have been landed.  Closing bug.
Comment 14 Ryan Haddad 2017-08-31 18:13:07 PDT
This change broke the Windows build:

C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\rendering\style\RenderStyle.h(1778): error C2666: 'WebCore::operator -': 7 overloads have similar conversions 

https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/4064
Comment 15 Daniel Bates 2017-08-31 19:02:29 PDT
(In reply to Ryan Haddad from comment #14)
> This change broke the Windows build:
> 
> C:\cygwin\home\buildbot\slave\win-
> release\build\Source\WebCore\rendering\style\RenderStyle.h(1778): error
> C2666: 'WebCore::operator -': 7 overloads have similar conversions 
> 
> https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/
> 4064

Committed attempt to fix the build in <http://trac.webkit.org/changeset/221467>.
Comment 16 Daniel Bates 2017-08-31 20:06:27 PDT
Committed another attempt to fix the Windows build <https://trac.webkit.org/changeset/221469>.
Comment 17 Yoshiaki Jitsukawa 2017-08-31 21:07:29 PDT
Created attachment 319571 [details]
Another patch to fix the wincairo build
Comment 18 Radar WebKit Bug Importer 2017-09-27 12:43:27 PDT
<rdar://problem/34693833>