Bug 176171 – Make RenderStyle's non-inherited flags more human friendly

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Daniel Bates]

Revert the change made in bug #130939 to make RenderStyle's non-inherited flags more JSC friendly as we never followed through to have the CSS JIT update RenderStyle directly.

[Daniel Bates]

Created attachment 319478 [details]
Patch

[Build Bot]

Comment on attachment 319478 [details]
Patch

Attachment 319478 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4417570

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 319484 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 319478 [details]
Patch

Attachment 319478 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4417579

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 319485 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 319478 [details]
Patch

Attachment 319478 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4417653

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 319488 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 319478 [details]
Patch

Attachment 319478 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4417718

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 319493 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Daniel Bates]

Created attachment 319529 [details]
Patch

[Daniel Bates]

Created attachment 319530 [details]
Patch

[Daniel Bates]

Comment on attachment 319530 [details]
Patch

Clearing flags on attachment: 319530

Committed r221459: <http://trac.webkit.org/changeset/221459>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

This change broke the Windows build:

C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\rendering\style\RenderStyle.h(1778): error C2666: 'WebCore::operator -': 7 overloads have similar conversions 

https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/4064

[Daniel Bates]

(In reply to Ryan Haddad from comment #14)
> This change broke the Windows build:
> 
> C:\cygwin\home\buildbot\slave\win-
> release\build\Source\WebCore\rendering\style\RenderStyle.h(1778): error
> C2666: 'WebCore::operator -': 7 overloads have similar conversions 
> 
> https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/
> 4064

Committed attempt to fix the build in <http://trac.webkit.org/changeset/221467>.

[Daniel Bates]

Committed another attempt to fix the Windows build <https://trac.webkit.org/changeset/221469>.

[Yoshiaki Jitsukawa]

Created attachment 319571 [details]
Another patch to fix the wincairo build

[Radar WebKit Bug Importer]

<rdar://problem/34693833>