Make RenderStyle's non inherited flags more JSC friendly
Created attachment 228120 [details] Patch
Attachment 228120 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/style/RenderStyle.h:471: noninherited_flags is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 228120 [details] Patch r=me! Would it be possible to mash the ref count together with the flag bits somehow in the future?
Comment on attachment 228120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228120&action=review > Source/WebCore/rendering/style/RenderStyle.h:165 > + // Only a subset i copied because NonInheritedFlags contains a bunch of stuff other than real style data. i copied -> is copied
Committed r166465: <http://trac.webkit.org/changeset/166465>
(In reply to comment #3) > (From update of attachment 228120 [details]) > r=me! > > Would it be possible to mash the ref count together with the flag bits somehow in the future? Looks like there are only 24 bits left in total. A bit short for the ref count. If we use TBI we can get rid of tons of stuff. The change would be big though :)
(In reply to comment #6) > (In reply to comment #3) > > (From update of attachment 228120 [details] [details]) > > r=me! > > > > Would it be possible to mash the ref count together with the flag bits somehow in the future? > > > Looks like there are only 24 bits left in total. A bit short for the ref count. > > If we use TBI we can get rid of tons of stuff. The change would be big though :) We could also move some of the rarely-used flags to substructures. Anyways, NABD, but something to consider in the future.
It broke the Apple Windows debug build.
This broke the Windows build, probably because it is 32-bit: 12>c:\projects\webkit\opensource\source\webcore\rendering\style\RenderStyle.cpp(78): error C2338: RenderStyle_should_stay_small (..\rendering\style\StyleAllInOne.cpp)