Bug 176142 – Speedometer 2.0: Add dummy node to notify app is ready for Backbone suite

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Shiyu Zhang]

There's a chance for BackboneJS suite that Speedometer attempted to add items before app.js was loaded. The deleteButtons.length in resources/test.js for BackboneJS suite could be zero sometimes as I observed. What's worse, BackboneJS suite will just skip complete/delete-items steps and never crash if checkboxes/deleteButtons.length is zero, which makes this issue difficult to be detected.

[Shiyu Zhang]

Created attachment 319437 [details]
Patch

[Shiyu Zhang]

Comment on attachment 319437 [details]
Patch

A patch to fix this bug, PTAL.

[Ryosuke Niwa]

Comment on attachment 319437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319437&action=review

> PerformanceTests/Speedometer/resources/tests.js:233
> +            var newTodo = contentDocument.getElementsByClassName('new-todo');
> +            newTodo[0].focus();
> +            return newTodo[0];

I think it's cleaner to use querySelector here.

[Ryosuke Niwa]

Comment on attachment 319437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319437&action=review

>> PerformanceTests/Speedometer/resources/tests.js:233
>> +            return newTodo[0];
> 
> I think it's cleaner to use querySelector here.

Can we also replace checkboxes.length and deleteButtons.length by numberOfItemsToAdd below
so that we'd see a console error should this bug come back?

[Shiyu Zhang]

Created attachment 319831 [details]
Patch

[Shiyu Zhang]

Comment on attachment 319831 [details]
Patch

Thanks for your advice! A new patch following your suggestion is here.

[WebKit Commit Bot]

Comment on attachment 319831 [details]
Patch

Clearing flags on attachment: 319831

Committed r221611: <http://trac.webkit.org/changeset/221611>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34694038>