REGRESSION(r220235): Web Inspector: Global search should not happen incrementally Incremental search is bad at the global search level because a slowly typed search string could result in full text search of strings like "a" which result in many, many results and unfortunately slow performance during that process. Steps to reproduce: 1. Inspect this page 2. Type "a" in the search field => Search happens even though I didn't consider my search term complete yet Regression: (bug 175108) > - this._searchToolbarItem = new WI.SearchBar("inspector-search", WI.UIString("Search"), null, true); > + this._searchToolbarItem = new WI.SearchBar("inspector-search", WI.UIString("Search"), true); Notes: - It does seem we can remove the unused delegate of WI.SearchBar.
Created attachment 319279 [details] [PATCH] Proposed Fix
Comment on attachment 319279 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=319279&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Main.js:401 > + const incremental = false; > + this._searchToolbarItem = new WI.SearchBar("inspector-search", WI.UIString("Search"), incremental); NIT: since this is false, I don't think you need to include it at all.
Comment on attachment 319279 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=319279&action=review >> Source/WebInspectorUI/UserInterface/Base/Main.js:401 >> + this._searchToolbarItem = new WI.SearchBar("inspector-search", WI.UIString("Search"), incremental); > > NIT: since this is false, I don't think you need to include it at all. Correct. That said, I like being explicit here, so I'll leave it as is. If we ever add new options we could make this an options dictionary {optional: true}, etc.
Comment on attachment 319279 [details] [PATCH] Proposed Fix Clearing flags on attachment: 319279 Committed r221332: <http://trac.webkit.org/changeset/221332>
All reviewed patches have been landed. Closing bug.
<rdar://problem/34149530>