Bug 175108 - Web Inspector: add button to open Inspector^2
Summary: Web Inspector: add button to open Inspector^2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-02 19:00 PDT by Devin Rousso
Modified: 2017-08-03 16:12 PDT (History)
6 users (show)

See Also:


Attachments
Patch (16.23 KB, patch)
2017-08-02 19:03 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (544.35 KB, image/png)
2017-08-02 19:04 PDT, Devin Rousso
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-08-02 19:00:36 PDT
Words cannot describe my hatred for the fact that I cannot open Inspector^2 without clicking "Inspect Element" in the context menu of the Inspector page.  Furthermore, having it ALWAYS open to Elements is just awful, especially if I am doing work in Debugger/Timelines.
Comment 1 Devin Rousso 2017-08-02 19:03:54 PDT
Created attachment 317064 [details]
Patch
Comment 2 Devin Rousso 2017-08-02 19:04:51 PDT
Created attachment 317065 [details]
[Image] After Patch is applied
Comment 3 BJ Burg 2017-08-03 10:40:51 PDT
Comment on attachment 317064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317064&action=review

r=me

> Source/WebCore/inspector/InspectorFrontendHost.cpp:421
> +void InspectorFrontendHost::inspectInspector()

Did you test this in the remote inspection case? I am pretty sure it should Just Work but that doesn't mean a whole lot.
Comment 4 Devin Rousso 2017-08-03 15:41:17 PDT
Comment on attachment 317064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317064&action=review

>> Source/WebCore/inspector/InspectorFrontendHost.cpp:421
>> +void InspectorFrontendHost::inspectInspector()
> 
> Did you test this in the remote inspection case? I am pretty sure it should Just Work but that doesn't mean a whole lot.

I tried inspecting the simulator and it worked fine.
Comment 5 WebKit Commit Bot 2017-08-03 16:11:00 PDT
Comment on attachment 317064 [details]
Patch

Clearing flags on attachment: 317064

Committed r220235: <http://trac.webkit.org/changeset/220235>
Comment 6 WebKit Commit Bot 2017-08-03 16:11:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-08-03 16:12:03 PDT
<rdar://problem/33711711>