Bug 176054 - Layout test media/video-controls-in-media-document.html and media/video-controls-no-display-with-text-track.html are flaky.
Summary: Layout test media/video-controls-in-media-document.html and media/video-cont...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 116274 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-08-29 09:30 PDT by Matt Lewis
Modified: 2017-10-27 13:48 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2017-08-29 09:30:00 PDT
media/video-controls-in-media-document.html is a flaky failure according to the flakiness dashboard. This test was initially reported for failing with multiple other media tests however it has recently been consistently failing with media/video-controls-no-display-with-text-track.html only or on its own. The reverse is also true. There are still examples of these test failing in a much larger block as seen in the original bug: https://bugs.webkit.org/show_bug.cgi?id=173978

current build:

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r221294%20(3911)/results.html
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/3911

Diff for media/video-controls-in-media-document.html:

--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/media/video-controls-in-media-document-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/media/video-controls-in-media-document-actual.txt
@@ -2,5 +2,5 @@
 
 
 
-EXPECTED (controls.offsetTop + controls.offsetHeight <= '240') OK
+EXPECTED (controls.offsetTop + controls.offsetHeight <= '285'), OBSERVED 'NaN' FAIL
 

Diff for media/video-controls-no-display-with-text-track.html:

--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/media/video-controls-no-display-with-text-track-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/media/video-controls-no-display-with-text-track-actual.txt
@@ -7,6 +7,6 @@
 EVENT(webkitfullscreenchange)
 
 ** Video controls should be shown on fullscreen **
-EXPECTED (panel.style['display'] != 'none') OK
+TypeError: null is not an object (evaluating 'panel.style')
 END OF TEST
Comment 1 Matt Lewis 2017-08-29 09:30:36 PDT
*** Bug 116274 has been marked as a duplicate of this bug. ***
Comment 2 Matt Lewis 2017-08-29 09:53:40 PDT
Marked these test as flaky due to the amount of flakiness:
https://trac.webkit.org/changeset/221300/webkit
Comment 3 Matt Lewis 2017-10-27 13:48:55 PDT
These test are now flaky on High Sierra as well:

https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r224121%20(763)/results.html

Adjusted the expectations in:
https://trac.webkit.org/changeset/224129/webkit