RESOLVED FIXED 175924
Add support for RegExp "dotAll" flag 
https://bugs.webkit.org/show_bug.cgi?id=175924
Summary Add support for RegExp "dotAll" flag
Michael Saboff
Reported 2017-08-23 20:57:25 PDT
This is to add support for the ECMAScript proposed Regular Expression s (dotAll) flag. See https://github.com/tc39/proposal-regexp-dotall-flag for details.
Attachments
Patch (40.38 KB, patch)
2017-08-24 13:05 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2017-08-23 20:57:53 PDT
<rdar://problem/33324894>
Michael Saboff
Comment 2 2017-08-24 13:05:42 PDT
Created attachment 319014 [details] Patch
Keith Miller
Comment 3 2017-08-24 13:27:31 PDT
Comment on attachment 319014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319014&action=review r=me. > Source/JavaScriptCore/bytecode/BytecodeDumper.cpp:-263 > - if (regExp->sticky()) Why'd you move sticky out of curiosity?
Michael Saboff
Comment 4 2017-08-24 13:34:13 PDT
(In reply to Keith Miller from comment #3) > Comment on attachment 319014 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=319014&action=review > > r=me. > > > Source/JavaScriptCore/bytecode/BytecodeDumper.cpp:-263 > > - if (regExp->sticky()) > > Why'd you move sticky out of curiosity? To alphabetize the option letters since the function is creating of those letters.
WebKit Commit Bot
Comment 5 2017-08-24 14:14:47 PDT
Comment on attachment 319014 [details] Patch Clearing flags on attachment: 319014 Committed r221160: <http://trac.webkit.org/changeset/221160>
WebKit Commit Bot
Comment 6 2017-08-24 14:14:49 PDT
All reviewed patches have been landed. Closing bug.
Michael Saboff
Comment 7 2017-09-26 12:26:27 PDT
*** Bug 172634 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.