Bug 175871 - Speedometer 2.0: Async time is not always capturing layout time
Summary: Speedometer 2.0: Async time is not always capturing layout time
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 172339
  Show dependency treegraph
 
Reported: 2017-08-22 20:33 PDT by Ryosuke Niwa
Modified: 2017-08-23 14:43 PDT (History)
12 users (show)

See Also:


Attachments
Improves the harness (3.32 KB, patch)
2017-08-22 21:16 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-08-22 20:33:02 PDT
In some browsers, layout & paint happens in accordance with vsync / rAF.
This means that async time doesn't always capture the time to update the layout.

Work around this limitation by manually forcing the layout in async time measurement.
Comment 1 Ryosuke Niwa 2017-08-22 21:16:17 PDT
Created attachment 318851 [details]
Improves the harness
Comment 2 Ryosuke Niwa 2017-08-22 21:59:51 PDT
There's no measurable difference in the total score.

==Before==
Safari
117.0
118.3
115.7

Chrome
113.7
112.3
113.2

Firefox
79.91
78.17
79.60

==After==
Safari
116.7
117.9
118.4

Chrome
112.7
112.4
113.4

Firefox
79.39
79.68
79.10
Comment 3 Ryosuke Niwa 2017-08-23 14:40:43 PDT
Comment on attachment 318851 [details]
Improves the harness

Clearing flags on attachment: 318851

Committed r221106: <http://trac.webkit.org/changeset/221106>
Comment 4 Ryosuke Niwa 2017-08-23 14:40:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-08-23 14:43:57 PDT
<rdar://problem/34044521>