Bug 175816 - Speedometer 2.0: Add button to select and unselect all tests to InteractiveRunner.html
Summary: Speedometer 2.0: Add button to select and unselect all tests to InteractiveRu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 172339
  Show dependency treegraph
 
Reported: 2017-08-22 01:02 PDT by Ryosuke Niwa
Modified: 2017-08-22 13:43 PDT (History)
9 users (show)

See Also:


Attachments
Adds the buttons (2.04 KB, patch)
2017-08-22 01:07 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Removed superfluous newline (1.84 KB, patch)
2017-08-22 01:08 PDT, Ryosuke Niwa
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-08-22 01:02:14 PDT
Now that we have doubled the number of test cases in Speedometer,
we should have buttons to quickly select & unselect all test cases.
Comment 1 Ryosuke Niwa 2017-08-22 01:07:29 PDT
Created attachment 318745 [details]
Adds the buttons
Comment 2 Ryosuke Niwa 2017-08-22 01:08:21 PDT
Created attachment 318746 [details]
Removed superfluous newline
Comment 3 Saam Barati 2017-08-22 08:29:19 PDT
Comment on attachment 318746 [details]
Removed superfluous newline

View in context: https://bugs.webkit.org/attachment.cgi?id=318746&action=review

r=me

> PerformanceTests/Speedometer/InteractiveRunner.html:77
> +        for (var suiteIndex = 0; suiteIndex < suites.length; suiteIndex++) {

For of?

> PerformanceTests/Speedometer/InteractiveRunner.html:87
> +        for (var suiteIndex = 0; suiteIndex < suites.length; suiteIndex++) {

Ditto
Comment 4 Ryosuke Niwa 2017-08-22 13:40:20 PDT
(In reply to Saam Barati from comment #3)
> Comment on attachment 318746 [details]
> Removed superfluous newline
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=318746&action=review
> 
> r=me
> 
> > PerformanceTests/Speedometer/InteractiveRunner.html:77
> > +        for (var suiteIndex = 0; suiteIndex < suites.length; suiteIndex++) {
> 
> For of?

No, we don't want the runner code to require ES2015. We occasionally run the latest version of Speedometer in very old versions of Safari for validation purposes. See https://bugs.webkit.org/show_bug.cgi?id=172439 for example in which I ran trunk Speedometer on Safari 7.

>
> > PerformanceTests/Speedometer/InteractiveRunner.html:87
> > +        for (var suiteIndex = 0; suiteIndex < suites.length; suiteIndex++) {
> 
> Ditto

Ditto.
Comment 5 Ryosuke Niwa 2017-08-22 13:42:26 PDT
Committed r221039: <http://trac.webkit.org/changeset/221039>
Comment 6 Radar WebKit Bug Importer 2017-08-22 13:43:34 PDT
<rdar://problem/34020295>