Bug 175815 – REGRESSION(r216718): Speedometer 2.0: Fix vanilla JS examples

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

Vanilla JS & ES2015 test cases got broken again in https://trac.webkit.org/changeset/217107

We can't use new Date().getTime() to generate an unique ID.

[Ryosuke Niwa]

Created attachment 318744 [details]
Fixes the bug

[Ryosuke Niwa]

Comment on attachment 318744 [details]
Fixes the bug

bundle.app* files are generated from npm run build. See changes in
PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/store.js
PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/es2015/src/store.js
for the actual code/test change.

[Mathias Bynens]

Comment on attachment 318744 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=318744&action=review

> PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/store.js:5
> +var uniqueID = 0;

`vanilla-examples/es2015/src/store.js` has the same line but uses `let` instead of `var` and starts at `1` instead of `0`. Is there a reason for these subtle differences? If so, we may want to add a comment saying so.

[Mathias Bynens]

How did https://trac.webkit.org/changeset/220043/webkit(In reply to Ryosuke Niwa from comment #0)
> Vanilla JS & ES2015 test cases got broken again in
> https://trac.webkit.org/changeset/217107

That doesn’t seem like the right link.

This bug’s title refers to R220043 but that patch didn’t touch any JavaScript: https://trac.webkit.org/changeset/220043

Did you mean R216718 instead? https://trac.webkit.org/changeset/216718

[Ryosuke Niwa]

(In reply to Mathias Bynens from comment #3)
> Comment on attachment 318744 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=318744&action=review
> 
> > PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/store.js:5
> > +var uniqueID = 0;
> 
> `vanilla-examples/es2015/src/store.js` has the same line but uses `let`
> instead of `var` and starts at `1` instead of `0`. Is there a reason for
> these subtle differences? If so, we may want to add a comment saying so.

It looked like all variable declarations in this file was using `var` so I used that to be consistent.

(In reply to Mathias Bynens from comment #4)
> How did https://trac.webkit.org/changeset/220043/webkit(In reply to Ryosuke
> Niwa from comment #0)
> > Vanilla JS & ES2015 test cases got broken again in
> > https://trac.webkit.org/changeset/217107
> 
> That doesn’t seem like the right link.
> 
> This bug’s title refers to R220043 but that patch didn’t touch any
> JavaScript: https://trac.webkit.org/changeset/220043
> 
> Did you mean R216718 instead? https://trac.webkit.org/changeset/216718

Oops, fixed.

[Saam Barati]

Comment on attachment 318744 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=318744&action=review

>>> PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/store.js:5
>>> +var uniqueID = 0;
>> 
>> `vanilla-examples/es2015/src/store.js` has the same line but uses `let` instead of `var` and starts at `1` instead of `0`. Is there a reason for these subtle differences? If so, we may want to add a comment saying so.
> 
> It looked like all variable declarations in this file was using `var` so I used that to be consistent.
> 
> (In reply to Mathias Bynens from comment #4)

As Mathias asked, is there a reason to use 0 instead of 1 or vice versa?

[Ryosuke Niwa]

Oh oops, clearly, I need to start the value at 1.

[Ryosuke Niwa]

Committed r221054: <http://trac.webkit.org/changeset/221054>

[Radar WebKit Bug Importer]

<rdar://problem/34023999>