RESOLVED FIXED175696
Display detailed error logs when a script fails in EWS 
https://bugs.webkit.org/show_bug.cgi?id=175696
Summary Display detailed error logs when a script fails in EWS
Aakash Jain
Reported 2017-08-17 16:29:45 PDT
When a script fails in EWS, most of the times it displays only last 500 characters of the output. This is usually not enough, and many times last 500 characters do not even contain the details of the actual error. For e.g. in https://webkit-queues.webkit.org/results/4332952, logs do not indicate why did svn-apply failed.
Attachments
Proposed patch (7.23 KB, patch)
2017-08-17 16:36 PDT, Aakash Jain 		darin: review+
DetailsFormatted DiffDiff
Updated patch (6.25 KB, patch)
2018-05-25 18:02 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-08-17 16:36:32 PDT
Created attachment 318438 [details] Proposed patch
Alexey Proskuryakov
Comment 2 2017-08-17 17:28:18 PDT
Comment on attachment 318438 [details] Proposed patch Where does this log go? If it's sent to the server, we may run into application defined limits.
Blaze Burg
Comment 3 2017-10-05 13:52:09 PDT
<rdar://problem/34841885>
Aakash Jain
Comment 4 2018-05-25 17:58:25 PDT
Noticed this issue in https://webkit-queues.webkit.org/results/7804250 (https://bugs.webkit.org/show_bug.cgi?id=185949). The error-message barely had the relevant message in it. We should have some more output.
Aakash Jain
Comment 5 2018-05-25 18:02:03 PDT
Created attachment 341368 [details] Updated patch Increasing the output limit from 500 characters (default) to 5000 characters. 5000 characters should give us more much information to act upon the error. It would help greatly in debugging commit-queue related failures (e.g.: 'git svn dcommit' failure).
Darin Adler
Comment 6 2018-05-25 20:30:39 PDT
Comment on attachment 341368 [details] Updated patch OK, lets try it
WebKit Commit Bot
Comment 7 2018-05-25 20:56:51 PDT
Comment on attachment 341368 [details] Updated patch Clearing flags on attachment: 341368 Committed r232222: <https://trac.webkit.org/changeset/232222>
WebKit Commit Bot
Comment 8 2018-05-25 20:56:53 PDT
All reviewed patches have been landed. Closing bug.
Aakash Jain
Comment 9 2018-06-01 14:49:57 PDT
This change seems to be working fine. https://bugs.webkit.org/show_bug.cgi?id=185949#c14 has longer error message making it actionable. Earlier the error message in the same bug wasn't very clear/actionable.
Blaze Burg
Comment 10 2018-06-04 10:32:13 PDT
Thanks Aakash!
Aakash Jain
Comment 11 2020-03-21 07:22:15 PDT
EWS has been re-implemented from scratch. New EWS uses buildbot and displays complete error logs, no truncation at all. Also the comments by commit-queue are now human friendly and do not contains large logs. e.g.: https://bugs.webkit.org/show_bug.cgi?id=209259#c6, https://bugs.webkit.org/show_bug.cgi?id=209355#c4, https://bugs.webkit.org/show_bug.cgi?id=209300#c3
Note You need to log in before you can comment on or make changes to this bug.