Bug 209259 - Allow for some tolerance when checking canvas pixels in fast/mediastream tests
Summary: Allow for some tolerance when checking canvas pixels in fast/mediastream tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-18 17:10 PDT by Eric Carlson
Modified: 2020-03-19 16:05 PDT (History)
9 users (show)

See Also:

Attachments
Patch (6.60 KB, patch)
2020-03-18 17:14 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (1.79 KB, patch)
2020-03-19 12:53 PDT, Eric Carlson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (1.75 KB, patch)
2020-03-19 13:13 PDT, Eric Carlson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (1.78 KB, patch)
2020-03-19 13:26 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (1.70 KB, patch)
2020-03-19 14:12 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2020-03-18 17:10:14 PDT 
Allow for some tolerance when checking canvas pixels in fast/mediastream tests
Comment 1 Radar WebKit Bug Importer 2020-03-18 17:10:25 PDT 
<rdar://problem/60609789>
Comment 2 Eric Carlson 2020-03-18 17:14:35 PDT 
Created attachment 393921 [details]
Patch
Comment 3 EWS 2020-03-19 08:34:12 PDT 
Committed r258700: <https://trac.webkit.org/changeset/258700>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 393921 [details].
Comment 4 Eric Carlson 2020-03-19 12:53:11 PDT 
Reopening to attach new patch.
Comment 5 Eric Carlson 2020-03-19 12:53:12 PDT 
Created attachment 394007 [details]
Patch
Comment 6 EWS 2020-03-19 12:54:43 PDT 
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Comment 7 Eric Carlson 2020-03-19 13:13:19 PDT 
Created attachment 394010 [details]
Patch
Comment 8 EWS 2020-03-19 13:14:35 PDT 
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 9 Eric Carlson 2020-03-19 13:26:34 PDT 
Created attachment 394013 [details]
Patch
Comment 10 Eric Carlson 2020-03-19 14:12:50 PDT 
Created attachment 394022 [details]
Patch
Comment 11 EWS 2020-03-19 16:05:30 PDT 
Committed r258739: <https://trac.webkit.org/changeset/258739>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394022 [details].