Bug 175623 - Speedometer: Update to modern Angular 1 version
Summary: Speedometer: Update to modern Angular 1 version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 172339
  Show dependency tree / graph
 
Reported: 2017-08-16 03:36 PDT by Mathias Bynens
Modified: 2017-08-16 12:19 PDT (History)
7 users (show)

See Also:

Attachments
Patch (649.46 KB, patch)
2017-08-16 03:41 PDT, Mathias Bynens 		no flags Details | Formatted Diff | Diff
Patch (1.65 MB, patch)
2017-08-16 03:51 PDT, Mathias Bynens 		no flags Details | Formatted Diff | Diff
Patch (1.65 MB, patch)
2017-08-16 05:29 PDT, Mathias Bynens 		no flags Details | Formatted Diff | Diff
Results before and after the patch (93.82 KB, application/pdf)
2017-08-16 06:20 PDT, Mathias Bynens 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Bynens 2017-08-16 03:36:47 PDT 
Speedometer: Document Angular 1.4 TodoMVC example
Comment 1 Mathias Bynens 2017-08-16 03:41:25 PDT 
Created attachment 318248 [details]
Patch
Comment 2 Mathias Bynens 2017-08-16 03:51:26 PDT 
Created attachment 318250 [details]
Patch
Comment 3 Mathias Bynens 2017-08-16 04:04:51 PDT 
Hmm… Why are the style checks failing? Is there an easy way to run these tests locally?

FWIW, I didn’t get any errors when running `webkit-patch`:

    $ webkit-patch upload --request-commit
    Total errors found: 0 in 16 files
    […]
Comment 4 Mathias Bynens 2017-08-16 05:29:23 PDT 
Created attachment 318256 [details]
Patch
Comment 5 Mathias Bynens 2017-08-16 05:33:39 PDT 
(In reply to Mathias Bynens from comment #3)
> Hmm… Why are the style checks failing? Is there an easy way to run these
> tests locally?
> 
> FWIW, I didn’t get any errors when running `webkit-patch`:
> 
>     $ webkit-patch upload --request-commit
>     Total errors found: 0 in 16 files
>     […]

Seems to have been caused by me renaming `readme.md` to `README.md` (for consistency). The same patch minus that change passes the checks. 🤷🏼
Comment 6 Mathias Bynens 2017-08-16 06:20:02 PDT 
Created attachment 318257 [details]
Results before and after the patch
Comment 7 WebKit Commit Bot 2017-08-16 12:17:46 PDT 
Comment on attachment 318256 [details]
Patch

Clearing flags on attachment: 318256

Committed r220801: <http://trac.webkit.org/changeset/220801>
Comment 8 WebKit Commit Bot 2017-08-16 12:17:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-08-16 12:19:38 PDT 
<rdar://problem/33924148>