Bug 175549 - Add some convenience utility accessor methods to MacroAssembler::CPUState.
Summary: Add some convenience utility accessor methods to MacroAssembler::CPUState.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks: 174645
  Show dependency treegraph
 
Reported: 2017-08-14 15:17 PDT by Mark Lam
Modified: 2017-08-14 15:56 PDT (History)
7 users (show)

See Also:


Attachments
proposed patch. (4.57 KB, patch)
2017-08-14 15:35 PDT, Mark Lam
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-08-14 15:17:51 PDT
Patch coming.
Comment 1 Radar WebKit Bug Importer 2017-08-14 15:18:27 PDT
<rdar://problem/33884868>
Comment 2 Mark Lam 2017-08-14 15:35:56 PDT
Created attachment 318075 [details]
proposed patch.
Comment 3 Saam Barati 2017-08-14 15:39:48 PDT
Comment on attachment 318075 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=318075&action=review

> Source/JavaScriptCore/assembler/MacroAssembler.h:1869
> +    template<typename T, typename std::enable_if<std::is_pointer<T>::value>::type* = nullptr>

I don't think you need the = nullptr and the * type.
Comment 4 Mark Lam 2017-08-14 15:51:54 PDT
Thanks for the review.

(In reply to Saam Barati from comment #3)
> Comment on attachment 318075 [details]
> proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=318075&action=review
> 
> > Source/JavaScriptCore/assembler/MacroAssembler.h:1869
> > +    template<typename T, typename std::enable_if<std::is_pointer<T>::value>::type* = nullptr>
> 
> I don't think you need the = nullptr and the * type.

Without the "* = nullptr", Clang complains: candidate template ignored: couldn't infer template argument ''.

I'll land it as is.
Comment 5 Mark Lam 2017-08-14 15:56:01 PDT
Landed in r220720: <http://trac.webkit.org/r220720>.