Bug 175458 - Web Inspector: Styles: Update the filter icon to match Xcode
Summary: Web Inspector: Styles: Update the filter icon to match Xcode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks: 175450
  Show dependency tree / graph
 
Reported: 2017-08-10 16:28 PDT by Nikita Vasilyev
Modified: 2017-08-11 14:09 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.95 KB, patch)
2017-08-10 16:32 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Image] With patch applied (20.33 KB, image/png)
2017-08-10 16:44 PDT, Nikita Vasilyev 		no flags Details
[Image] Xcode's icon offsets (47.62 KB, image/png)
2017-08-10 17:28 PDT, Matt Baker 		no flags Details
Patch (13.06 KB, patch)
2017-08-11 13:08 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Image] With patch applied (6.63 KB, image/png)
2017-08-11 13:09 PDT, Nikita Vasilyev 		no flags Details
Patch (13.36 KB, patch)
2017-08-11 13:24 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2017-08-10 16:28:15 PDT 
Update the icon that is used:
— At the bottom of the "Styles — Rules" panel.
— Node panel, Event Listeners section.
Comment 1 Radar WebKit Bug Importer 2017-08-10 16:28:34 PDT 
<rdar://problem/33838660>
Comment 2 Nikita Vasilyev 2017-08-10 16:32:32 PDT 
Created attachment 317879 [details]
Patch
Comment 3 Nikita Vasilyev 2017-08-10 16:44:23 PDT 
Created attachment 317882 [details]
[Image] With patch applied
Comment 4 Matt Baker 2017-08-10 17:28:08 PDT 
Created attachment 317893 [details]
[Image] Xcode's icon offsets

We might as well match Xcode (assuming this is the system UI) exactly. I think our values are slightly off.
Comment 5 Matt Baker 2017-08-10 17:28:40 PDT 
I'd also be in favor of changing the placeholder text to just "Filter", for all instances. I don't believe there is any ambiguity.
Comment 6 Nikita Vasilyev 2017-08-11 13:08:21 PDT 
Created attachment 317953 [details]
Patch
Comment 7 Nikita Vasilyev 2017-08-11 13:09:21 PDT 
Created attachment 317954 [details]
[Image] With patch applied

Now it matches Xcode's spacing exactly.
Comment 8 Nikita Vasilyev 2017-08-11 13:24:36 PDT 
Created attachment 317956 [details]
Patch
Comment 9 Matt Baker 2017-08-11 13:27:13 PDT 
Comment on attachment 317956 [details]
Patch

r=me
Comment 10 WebKit Commit Bot 2017-08-11 14:09:01 PDT 
Comment on attachment 317956 [details]
Patch

Clearing flags on attachment: 317956

Committed r220609: <http://trac.webkit.org/changeset/220609>
Comment 11 WebKit Commit Bot 2017-08-11 14:09:03 PDT 
All reviewed patches have been landed.  Closing bug.