RESOLVED FIXED 175458
Web Inspector: Styles: Update the filter icon to match Xcode 
https://bugs.webkit.org/show_bug.cgi?id=175458
Summary Web Inspector: Styles: Update the filter icon to match Xcode
Nikita Vasilyev
Reported 2017-08-10 16:28:15 PDT
Update the icon that is used: — At the bottom of the "Styles — Rules" panel. — Node panel, Event Listeners section.
Attachments
Patch (2.95 KB, patch)
2017-08-10 16:32 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Image] With patch applied (20.33 KB, image/png)
2017-08-10 16:44 PDT, Nikita Vasilyev 		no flags
Details
[Image] Xcode's icon offsets (47.62 KB, image/png)
2017-08-10 17:28 PDT, Matt Baker 		no flags
Details
Patch (13.06 KB, patch)
2017-08-11 13:08 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Image] With patch applied (6.63 KB, image/png)
2017-08-11 13:09 PDT, Nikita Vasilyev 		no flags
Details
Patch (13.36 KB, patch)
2017-08-11 13:24 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-08-10 16:28:34 PDT
<rdar://problem/33838660>
Nikita Vasilyev
Comment 2 2017-08-10 16:32:32 PDT
Created attachment 317879 [details] Patch
Nikita Vasilyev
Comment 3 2017-08-10 16:44:23 PDT
Created attachment 317882 [details] [Image] With patch applied
Matt Baker
Comment 4 2017-08-10 17:28:08 PDT
Created attachment 317893 [details] [Image] Xcode's icon offsets We might as well match Xcode (assuming this is the system UI) exactly. I think our values are slightly off.
Matt Baker
Comment 5 2017-08-10 17:28:40 PDT
I'd also be in favor of changing the placeholder text to just "Filter", for all instances. I don't believe there is any ambiguity.
Nikita Vasilyev
Comment 6 2017-08-11 13:08:21 PDT
Created attachment 317953 [details] Patch
Nikita Vasilyev
Comment 7 2017-08-11 13:09:21 PDT
Created attachment 317954 [details] [Image] With patch applied Now it matches Xcode's spacing exactly.
Nikita Vasilyev
Comment 8 2017-08-11 13:24:36 PDT
Created attachment 317956 [details] Patch
Matt Baker
Comment 9 2017-08-11 13:27:13 PDT
Comment on attachment 317956 [details] Patch r=me
WebKit Commit Bot
Comment 10 2017-08-11 14:09:01 PDT
Comment on attachment 317956 [details] Patch Clearing flags on attachment: 317956 Committed r220609: <http://trac.webkit.org/changeset/220609>
WebKit Commit Bot
Comment 11 2017-08-11 14:09:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.