Bug 175430 – Web Inspector: Remove text-shadow and gradient backgrounds

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Summary:
Remove text-shadow and gradient backgrounds. Web Inspector should be using a flat style throughout the UI.

[Matt Baker]

Created attachment 317845 [details]
Patch

[Matt Baker]

Created attachment 317846 [details]
[Image] Autocomplete popover - before/after

[Matt Baker]

Created attachment 317849 [details]
[Image] Timelines call frames popover - before/after

[Matt Baker]

Created attachment 317850 [details]
[Image] Sidebar "No Filter Results" - before/after

[Matt Baker]

The selected item background in the call frames popover should be full bleed (go all the way to the edges of the popover, be clipped by rounded corners) but this will be done in a follow-up.

[Matt Baker]

Created attachment 317851 [details]
Patch

[Nikita Vasilyev]

Comment on attachment 317851 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317851&action=review

Looks good! One comment:

> Source/WebInspectorUI/UserInterface/Views/RecordingTraceDetailsSidebarPanel.css:47
> -    font-size: 13px;
> +    font-size: var(--sidebar-panel-content-message-font-size);

Did you change the font size from 13px...

> Source/WebInspectorUI/UserInterface/Views/Variables.css:61
> +    --sidebar-panel-content-message-font-size: 16px;

to 16px?

[Matt Baker]

I did. Our font was much smaller than the same UI in Xcode and Mail. 16px is still smaller, but matching the size exactly felt too big.

[Nikita Vasilyev]

(In reply to Matt Baker from comment #8)
> I did. Our font was much smaller than the same UI in Xcode and Mail. 16px is
> still smaller, but matching the size exactly felt too big.

Does it affect anything other than "No Filter Results" message? If not, "--sidebar-panel-content-message-font-size" is too generic for a variable name.

[Matt Baker]

Created attachment 317981 [details]
Patch

[Nikita Vasilyev]

Looks good to me, but I'm not a reviewer.

[Blaze Burg]

Comment on attachment 317981 [details]
Patch

r=me

There are other similar things to clean up, such as the popover's outline / drop shadow.

[WebKit Commit Bot]

Comment on attachment 317981 [details]
Patch

Clearing flags on attachment: 317981

Committed r220710: <http://trac.webkit.org/changeset/220710>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33878673>