[GTK] Web Inspector: Add Canvas2D.svg and Canvas3D.svg Canvas.svg was renamed to Canvas3D.svg in Bug 174057.
Created attachment 317681 [details] Patch
Created attachment 317682 [details] screenshot with and without applying this change
Oh, no. This patch will break GTK+ incremental build because of removing an image file. I need to do something before landing this patch. (Bug 154088 Comment 4)
Created attachment 318236 [details] Patch
Created attachment 318238 [details] Patch
Created attachment 321508 [details] Patch
Comment on attachment 321508 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321508&action=review Thanks! > Tools/Scripts/webkitdirs.pm:1977 > + if (isGtk() or isWPE()) { > + my $gtkImageDircetory = File::Spec->catdir(sourceDir(), "Source", "WebInspectorUI", "UserInterface", "Images", "gtk"); > + if ($cacheFileModifiedTime < stat($gtkImageDircetory)->mtime) { > + return 1; > + } > + } This is a great idea! but I don't think it belongs to this commit. Could you please move this to its own bug/patch? You can submit the patch already reviewed and only ask for cq?
Created attachment 321948 [details] Patch
Comment on attachment 321948 [details] Patch Clearing flags on attachment: 321948 Committed r222552: <http://trac.webkit.org/changeset/222552>
All reviewed patches have been landed. Closing bug.
<rdar://problem/34694208>