Bug 175364 - [GTK] Web Inspector: Add Canvas2D.svg and Canvas3D.svg
Summary: [GTK] Web Inspector: Add Canvas2D.svg and Canvas3D.svg
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on: 174057 177349
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-08 20:53 PDT by Fujii Hironori
Modified: 2017-09-27 12:53 PDT (History)
8 users (show)

See Also:


Attachments
Patch (4.71 KB, patch)
2017-08-08 23:17 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
screenshot with and without applying this change (19.06 KB, image/png)
2017-08-08 23:41 PDT, Fujii Hironori
no flags Details
Patch (6.28 KB, patch)
2017-08-15 22:53 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch (6.31 KB, patch)
2017-08-15 23:10 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch (6.33 KB, patch)
2017-09-21 19:40 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch (4.77 KB, patch)
2017-09-27 02:55 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2017-08-08 20:53:30 PDT
[GTK] Web Inspector: Add Canvas2D.svg and Canvas3D.svg

Canvas.svg was renamed to Canvas3D.svg in Bug 174057.
Comment 1 Fujii Hironori 2017-08-08 23:17:26 PDT
Created attachment 317681 [details]
Patch
Comment 2 Fujii Hironori 2017-08-08 23:41:08 PDT
Created attachment 317682 [details]
screenshot with and without applying this change
Comment 3 Fujii Hironori 2017-08-08 23:59:26 PDT
Oh, no. This patch will break GTK+ incremental build because of removing an image file.
I need to do something before landing this patch. (Bug 154088 Comment 4)
Comment 4 Fujii Hironori 2017-08-15 22:53:26 PDT
Created attachment 318236 [details]
Patch
Comment 5 Fujii Hironori 2017-08-15 23:10:53 PDT
Created attachment 318238 [details]
Patch
Comment 6 Fujii Hironori 2017-09-21 19:40:52 PDT
Created attachment 321508 [details]
Patch
Comment 7 Carlos Garcia Campos 2017-09-22 00:11:28 PDT
Comment on attachment 321508 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321508&action=review

Thanks!

> Tools/Scripts/webkitdirs.pm:1977
> +    if (isGtk() or isWPE()) {
> +        my $gtkImageDircetory = File::Spec->catdir(sourceDir(), "Source", "WebInspectorUI", "UserInterface", "Images", "gtk");
> +        if ($cacheFileModifiedTime < stat($gtkImageDircetory)->mtime) {
> +            return 1;
> +        }
> +    }

This is a great idea! but I don't think it belongs to this commit. Could you please move this to its own bug/patch? You can submit the patch already reviewed and only ask for cq?
Comment 8 Fujii Hironori 2017-09-27 02:55:10 PDT
Created attachment 321948 [details]
Patch
Comment 9 WebKit Commit Bot 2017-09-27 03:50:35 PDT
Comment on attachment 321948 [details]
Patch

Clearing flags on attachment: 321948

Committed r222552: <http://trac.webkit.org/changeset/222552>
Comment 10 WebKit Commit Bot 2017-09-27 03:50:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2017-09-27 12:53:12 PDT
<rdar://problem/34694208>