Bug 174057 - Web Inspector: Split Canvas.svg into icons for 2D and 3D
Summary: Web Inspector: Split Canvas.svg into icons for 2D and 3D
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 175364
  Show dependency treegraph
 
Reported: 2017-06-30 17:09 PDT by Devin Rousso
Modified: 2017-08-08 20:53 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.68 KB, patch)
2017-06-30 17:10 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (34.73 KB, image/png)
2017-06-30 17:10 PDT, Devin Rousso
no flags Details
Patch (2.65 KB, patch)
2017-07-05 11:07 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (33.76 KB, image/png)
2017-07-05 11:07 PDT, Devin Rousso
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-06-30 17:09:48 PDT
Instead of trying to have a separate icon for each context type, we should just have one to distinguish 2d from WebGL/WebGl2.
Comment 1 Devin Rousso 2017-06-30 17:10:46 PDT
Created attachment 314328 [details]
Patch
Comment 2 Devin Rousso 2017-06-30 17:10:56 PDT
Created attachment 314329 [details]
[Image] After Patch is applied
Comment 3 BJ Burg 2017-07-03 11:01:04 PDT
(In reply to Devin Rousso from comment #2)
> Created attachment 314329 [details]
> [Image] After Patch is applied

Something about this looks wrong. I would expect the box to be in the frontmost layer since that's what I focus on first. Maybe put the circle in upper right and triangle at center bottom. Or, try using 3 overlapping squares?
Comment 4 Radar WebKit Bug Importer 2017-07-04 04:31:42 PDT
<rdar://problem/33122063>
Comment 5 Devin Rousso 2017-07-05 11:07:09 PDT
Created attachment 314621 [details]
Patch
Comment 6 Devin Rousso 2017-07-05 11:07:20 PDT
Created attachment 314622 [details]
[Image] After Patch is applied
Comment 7 Matt Baker 2017-07-05 19:12:12 PDT
Comment on attachment 314621 [details]
Patch

r=me. I think the changes suggested by Brian makes the icon more readable.
Comment 8 WebKit Commit Bot 2017-07-05 19:29:09 PDT
Comment on attachment 314621 [details]
Patch

Clearing flags on attachment: 314621

Committed r219180: <http://trac.webkit.org/changeset/219180>
Comment 9 WebKit Commit Bot 2017-07-05 19:29:10 PDT
All reviewed patches have been landed.  Closing bug.