RESOLVED FIXED 174057
Web Inspector: Split Canvas.svg into icons for 2D and 3D 
https://bugs.webkit.org/show_bug.cgi?id=174057
Summary Web Inspector: Split Canvas.svg into icons for 2D and 3D
Devin Rousso
Reported 2017-06-30 17:09:48 PDT
Instead of trying to have a separate icon for each context type, we should just have one to distinguish 2d from WebGL/WebGl2.
Attachments
Patch (2.68 KB, patch)
2017-06-30 17:10 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (34.73 KB, image/png)
2017-06-30 17:10 PDT, Devin Rousso 		no flags
Details
Patch (2.65 KB, patch)
2017-07-05 11:07 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (33.76 KB, image/png)
2017-07-05 11:07 PDT, Devin Rousso 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-06-30 17:10:46 PDT
Created attachment 314328 [details] Patch
Devin Rousso
Comment 2 2017-06-30 17:10:56 PDT
Created attachment 314329 [details] [Image] After Patch is applied
Blaze Burg
Comment 3 2017-07-03 11:01:04 PDT
(In reply to Devin Rousso from comment #2) > Created attachment 314329 [details] > [Image] After Patch is applied Something about this looks wrong. I would expect the box to be in the frontmost layer since that's what I focus on first. Maybe put the circle in upper right and triangle at center bottom. Or, try using 3 overlapping squares?
Radar WebKit Bug Importer
Comment 4 2017-07-04 04:31:42 PDT
<rdar://problem/33122063>
Devin Rousso
Comment 5 2017-07-05 11:07:09 PDT
Created attachment 314621 [details] Patch
Devin Rousso
Comment 6 2017-07-05 11:07:20 PDT
Created attachment 314622 [details] [Image] After Patch is applied
Matt Baker
Comment 7 2017-07-05 19:12:12 PDT
Comment on attachment 314621 [details] Patch r=me. I think the changes suggested by Brian makes the icon more readable.
WebKit Commit Bot
Comment 8 2017-07-05 19:29:09 PDT
Comment on attachment 314621 [details] Patch Clearing flags on attachment: 314621 Committed r219180: <http://trac.webkit.org/changeset/219180>
WebKit Commit Bot
Comment 9 2017-07-05 19:29:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.