Bug 175272 - Layout test accessibility/press-target-uses-text-descendant-node.html is flaky.
Summary: Layout test accessibility/press-target-uses-text-descendant-node.html is flaky.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-07 11:14 PDT by Matt Lewis
Modified: 2017-08-10 18:42 PDT (History)
12 users (show)

See Also:

Attachments
patch (1.39 KB, patch)
2017-08-09 12:33 PDT, Nan Wang 		no flags Details | Formatted Diff | Diff
patch (2.03 KB, patch)
2017-08-10 15:08 PDT, Nan Wang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2017-08-07 11:14:01 PDT 
The test accessibility/press-target-uses-text-descendant-node.html is flaky on macOS Debug according to the flakiness dashboard.

The test looks to have been flaky on these platforms since addition in https://trac.webkit.org/changeset/219906/webkit

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r220333%20(2400)/results.html
https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/2400


diff:
--- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/accessibility/press-target-uses-text-descendant-node-expected.txt
+++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/accessibility/press-target-uses-text-descendant-node-actual.txt
@@ -4,10 +4,10 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-Clicked on element: SPAN
 
 Now pressing on button
 
+Clicked on element: SPAN
 Clicked on element: IMG
 PASS successfullyParsed is true
Comment 1 Radar WebKit Bug Importer 2017-08-07 11:14:19 PDT 
<rdar://problem/33756962>
Comment 2 Nan Wang 2017-08-07 11:16:08 PDT 
Will look into this
Comment 3 Nan Wang 2017-08-09 12:33:19 PDT 
Created attachment 317729 [details]
patch
Comment 4 chris fleizach 2017-08-09 13:44:57 PDT 
Comment on attachment 317729 [details]
patch

is there some way that's more deterministic? could we post an internal notification when the press happens and listen for that?
Comment 5 Nan Wang 2017-08-10 15:08:57 PDT 
Created attachment 317859 [details]
patch

update
Comment 6 WebKit Commit Bot 2017-08-10 18:41:59 PDT 
Comment on attachment 317859 [details]
patch

Clearing flags on attachment: 317859

Committed r220570: <http://trac.webkit.org/changeset/220570>
Comment 7 WebKit Commit Bot 2017-08-10 18:42:01 PDT 
All reviewed patches have been landed.  Closing bug.