WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 174849
AX: should dispatch accessibilityPerformPressAction async on MacOS
https://bugs.webkit.org/show_bug.cgi?id=174849
Summary
AX: should dispatch accessibilityPerformPressAction async on MacOS
Nan Wang
Reported
2017-07-25 18:05:12 PDT
If by performing press action on an object causes an alert to appear, VO will hang, because accessibilityPerformPressAction never gets a chance to return <
rdar://problem/32933114
>
Attachments
patch
(9.87 KB, patch)
2017-07-25 18:11 PDT
,
Nan Wang
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews102 for mac-elcapitan
(1.00 MB, application/zip)
2017-07-25 19:08 PDT
,
Build Bot
no flags
Details
patch
(12.10 KB, patch)
2017-07-25 19:12 PDT
,
Nan Wang
cfleizach
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Nan Wang
Comment 1
2017-07-25 18:11:14 PDT
Created
attachment 316414
[details]
patch
Build Bot
Comment 2
2017-07-25 19:08:57 PDT
Comment on
attachment 316414
[details]
patch
Attachment 316414
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/4187686
New failing tests: accessibility/mac/search-predicate.html media/media-controls-accessibility.html
Build Bot
Comment 3
2017-07-25 19:08:58 PDT
Created
attachment 316419
[details]
Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Nan Wang
Comment 4
2017-07-25 19:12:54 PDT
Created
attachment 316421
[details]
patch Fixed the test failure
chris fleizach
Comment 5
2017-07-26 00:18:06 PDT
Comment on
attachment 316421
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=316421&action=review
> LayoutTests/accessibility/mac/search-predicate.html:283 > startElement = accessibilityController.focusedElement.childAtIndex(0);
looks like this block should be indented now
Nan Wang
Comment 6
2017-07-26 00:37:56 PDT
(In reply to chris fleizach from
comment #5
)
> Comment on
attachment 316421
[details]
> patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=316421&action=review
> > > LayoutTests/accessibility/mac/search-predicate.html:283 > > startElement = accessibilityController.focusedElement.childAtIndex(0); > > looks like this block should be indented now
Okay.
Nan Wang
Comment 7
2017-07-26 00:39:03 PDT
Committed
r219906
: <
http://trac.webkit.org/changeset/219906
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug