Bug 175190 - Cleanup: simplify WebSockets code for RuntimeEnabledFeatures
Summary: Cleanup: simplify WebSockets code for RuntimeEnabledFeatures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on: 167044
Blocks:
  Show dependency tree / graph
 
Reported: 2017-08-04 09:16 PDT by BJ Burg
Modified: 2017-08-07 09:32 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.31 KB, patch)
2017-08-04 14:59 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-08-04 09:16:22 PDT 
.
Comment 1 BJ Burg 2017-08-04 14:59:30 PDT 
Created attachment 317297 [details]
Patch
Comment 2 Joseph Pecoraro 2017-08-05 16:46:45 PDT 
Comment on attachment 317297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317297&action=review

> Source/WebCore/Modules/websockets/WebSocket.idl:-38
> -    EnabledAtRuntime=WebSocket,

It's not accurate to say it wasn't used for anything when it was used for this! But I guess we don't expect anyone to toggle it off.
Comment 3 WebKit Commit Bot 2017-08-07 09:32:28 PDT 
Comment on attachment 317297 [details]
Patch

Clearing flags on attachment: 317297

Committed r220337: <http://trac.webkit.org/changeset/220337>
Comment 4 WebKit Commit Bot 2017-08-07 09:32:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-08-07 09:32:47 PDT 
<rdar://problem/33754436>