Remove ENABLE(WEB_SOCKET) guards. Core Web Features that all ports enable.
Created attachment 298841 [details] [PATCH] Proposed Fix - Needs webkit-dev approval but testing on bots
Hmm, I bet this won't apply because its on top of removing ENABLE(DETAILS_ELEMENT). I'll retry it in a day or so.
Created attachment 317031 [details] Patch
Created attachment 317130 [details] Patch
Comment on attachment 317130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317130&action=review > Source/WebCore/dom/EventTargetFactory.in:-40 > -WebSocket conditional=WEB_SOCKETS Oops, deleted the whole line instead of the conditional.
Created attachment 317172 [details] Patch
Comment on attachment 317172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317172&action=review r=me > Source/WebCore/page/RuntimeEnabledFeatures.cpp:65 > bool RuntimeEnabledFeatures::webSocketEnabled() const > { > return WebSocket::isAvailable(); > } WebSocket::setIsAvailable never appears to be called. So this appears to always be `true` now. I think we can remove the separate WebSocket::isAvailable / WebSocket::setIsAvailable path and replace it with normal RuntimeEnabledFeatures and m_webSocketEnabed bool. This can be done separately as a follow-up. > Tools/Scripts/webkitperl/FeatureList.pm:-390 > - define => "ENABLE_WEB_SOCKETS", default => 1, value => \$webSocketsSupport }, Remove $webSocketsSupport on line 138.
Committed r220250: <http://trac.webkit.org/changeset/220250>
<rdar://problem/33715469>