Bug 167044 - Remove ENABLE(WEB_SOCKET) guards
Summary: Remove ENABLE(WEB_SOCKET) guards
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks: 175190
  Show dependency treegraph
 
Reported: 2017-01-13 20:03 PST by Joseph Pecoraro
Modified: 2017-08-04 09:16 PDT (History)
3 users (show)

See Also:


Attachments
[PATCH] Proposed Fix - Needs webkit-dev approval but testing on bots (86.82 KB, patch)
2017-01-13 20:05 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
Patch (98.11 KB, patch)
2017-08-02 16:53 PDT, BJ Burg
no flags Details | Formatted Diff | Diff
Patch (98.68 KB, patch)
2017-08-03 10:53 PDT, BJ Burg
no flags Details | Formatted Diff | Diff
Patch (98.90 KB, patch)
2017-08-03 15:55 PDT, BJ Burg
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-01-13 20:03:36 PST
Remove ENABLE(WEB_SOCKET) guards.

Core Web Features that all ports enable.
Comment 1 Joseph Pecoraro 2017-01-13 20:05:56 PST
Created attachment 298841 [details]
[PATCH] Proposed Fix - Needs webkit-dev approval but testing on bots
Comment 2 Joseph Pecoraro 2017-01-13 20:06:29 PST
Hmm, I bet this won't apply because its on top of removing ENABLE(DETAILS_ELEMENT). I'll retry it in a day or so.
Comment 3 BJ Burg 2017-08-02 16:53:02 PDT
Created attachment 317031 [details]
Patch
Comment 4 BJ Burg 2017-08-03 10:53:17 PDT
Created attachment 317130 [details]
Patch
Comment 5 BJ Burg 2017-08-03 11:38:45 PDT
Comment on attachment 317130 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317130&action=review

> Source/WebCore/dom/EventTargetFactory.in:-40
> -WebSocket conditional=WEB_SOCKETS

Oops, deleted the whole line instead of the conditional.
Comment 6 BJ Burg 2017-08-03 15:55:07 PDT
Created attachment 317172 [details]
Patch
Comment 7 Joseph Pecoraro 2017-08-03 17:14:19 PDT
Comment on attachment 317172 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317172&action=review

r=me

> Source/WebCore/page/RuntimeEnabledFeatures.cpp:65
>  bool RuntimeEnabledFeatures::webSocketEnabled() const
>  {
>      return WebSocket::isAvailable();
>  }

WebSocket::setIsAvailable never appears to be called. So this appears to always be `true` now.

I think we can remove the separate WebSocket::isAvailable / WebSocket::setIsAvailable path and replace it with normal RuntimeEnabledFeatures and m_webSocketEnabed bool.

This can be done separately as a follow-up.

> Tools/Scripts/webkitperl/FeatureList.pm:-390
> -      define => "ENABLE_WEB_SOCKETS", default => 1, value => \$webSocketsSupport },

Remove $webSocketsSupport on line 138.
Comment 8 BJ Burg 2017-08-03 19:41:21 PDT
Committed r220250: <http://trac.webkit.org/changeset/220250>
Comment 9 Radar WebKit Bug Importer 2017-08-03 19:41:46 PDT
<rdar://problem/33715469>