RESOLVED FIXED 175148
[Curl] Extract a features to manage HTTP communication from ResourceHandle 
https://bugs.webkit.org/show_bug.cgi?id=175148
Summary [Curl] Extract a features to manage HTTP communication from ResourceHandle
Basuke Suzuki
Reported 2017-08-03 12:54:59 PDT
To make the ResourceHandle manageable, move actual HTTP communication tasks into new class which is sub class of CurlHandle. In the long run, the new class will help to serve NetworkLoadTask for WebKit. CurlHandle should keep as is because it will be used from other purpose such as WebSocket. That's why the new class is sub class of CurlHandle.
Attachments
patch (66.90 KB, patch)
2017-09-26 13:49 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
patch (66.97 KB, patch)
2017-09-26 14:09 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2017-08-03 13:04:04 PDT
This class must has following features: - ref counted (to have different life span with ResourceHandle) - thread safe (to manage background callback and make ResourceHandle work only on main thread) - can manage curl callbacks internally (to make ResourceHandle simple)
Basuke Suzuki
Comment 2 2017-09-26 13:35:53 PDT
*** Bug 177497 has been marked as a duplicate of this bug. ***
Basuke Suzuki
Comment 3 2017-09-26 13:49:57 PDT
Created attachment 321863 [details] patch
Basuke Suzuki
Comment 4 2017-09-26 14:09:46 PDT
Created attachment 321866 [details] patch
WebKit Commit Bot
Comment 5 2017-09-29 14:19:36 PDT
Comment on attachment 321866 [details] patch Clearing flags on attachment: 321866 Committed r222665: <http://trac.webkit.org/changeset/222665>
WebKit Commit Bot
Comment 6 2017-09-29 14:19:37 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-09-29 14:20:20 PDT
<rdar://problem/34747397>
Note You need to log in before you can comment on or make changes to this bug.