Bug 175148 - [Curl] Extract a features to manage HTTP communication from ResourceHandle
Summary: [Curl] Extract a features to manage HTTP communication from ResourceHandle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
: 177497 (view as bug list)
Depends on: 177496
Blocks: 21242 173964 175149
  Show dependency tree / graph
 
Reported: 2017-08-03 12:54 PDT by Basuke Suzuki
Modified: 2017-09-29 14:20 PDT (History)
6 users (show)

See Also:

Attachments
patch (66.90 KB, patch)
2017-09-26 13:49 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
patch (66.97 KB, patch)
2017-09-26 14:09 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2017-08-03 12:54:59 PDT 
To make the ResourceHandle manageable, move actual HTTP communication tasks into new class which is sub class of CurlHandle.

In the long run, the new class will help to serve NetworkLoadTask for WebKit.

CurlHandle should keep as is because it will be used from other purpose such as WebSocket. That's why the new class is sub class of CurlHandle.
Comment 1 Basuke Suzuki 2017-08-03 13:04:04 PDT 
This class must has following features:
- ref counted (to have different life span with ResourceHandle)
- thread safe (to manage background callback and make ResourceHandle work only on main thread)
- can manage curl callbacks internally (to make ResourceHandle simple)
Comment 2 Basuke Suzuki 2017-09-26 13:35:53 PDT 
*** Bug 177497 has been marked as a duplicate of this bug. ***
Comment 3 Basuke Suzuki 2017-09-26 13:49:57 PDT 
Created attachment 321863 [details]
patch
Comment 4 Basuke Suzuki 2017-09-26 14:09:46 PDT 
Created attachment 321866 [details]
patch
Comment 5 WebKit Commit Bot 2017-09-29 14:19:36 PDT 
Comment on attachment 321866 [details]
patch

Clearing flags on attachment: 321866

Committed r222665: <http://trac.webkit.org/changeset/222665>
Comment 6 WebKit Commit Bot 2017-09-29 14:19:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-09-29 14:20:20 PDT 
<rdar://problem/34747397>