Bug 175132 - Fix parsing of <meta http-equiv=refresh> to allow time starting with a '.' without a leading 0
Summary: Fix parsing of <meta http-equiv=refresh> to allow time starting with a '.' wi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://github.com/whatwg/html/issues...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-03 06:32 PDT by Anne van Kesteren
Modified: 2017-08-03 21:38 PDT (History)
11 users (show)

See Also:


Attachments
Patch (26.49 KB, patch)
2017-08-03 15:54 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (999.90 KB, application/zip)
2017-08-03 16:57 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews115 for mac-elcapitan (1.77 MB, application/zip)
2017-08-03 17:18 PDT, Build Bot
no flags Details
Patch (28.34 KB, patch)
2017-08-03 19:35 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (28.37 KB, patch)
2017-08-03 19:44 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2017-08-03 06:32:17 PDT
Due to a change to the HTML Standard discussed at https://github.com/whatwg/html/issues/2844 we ended up regressing bug 161543:

  html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html

Apologies for the late notice, I didn't catch this during review.
Comment 1 Chris Dumez 2017-08-03 15:54:29 PDT
Created attachment 317171 [details]
Patch
Comment 2 Build Bot 2017-08-03 16:56:59 PDT
Comment on attachment 317171 [details]
Patch

Attachment 317171 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4249313

New failing tests:
imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1.html
imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2.html
Comment 3 Build Bot 2017-08-03 16:57:00 PDT
Created attachment 317181 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-08-03 17:18:49 PDT
Comment on attachment 317171 [details]
Patch

Attachment 317171 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4249332

New failing tests:
imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1.html
imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2.html
Comment 5 Build Bot 2017-08-03 17:18:51 PDT
Created attachment 317184 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Chris Dumez 2017-08-03 19:35:36 PDT
Created attachment 317201 [details]
Patch
Comment 7 Chris Dumez 2017-08-03 19:44:22 PDT
Created attachment 317205 [details]
Patch
Comment 8 WebKit Commit Bot 2017-08-03 21:37:14 PDT
Comment on attachment 317205 [details]
Patch

Clearing flags on attachment: 317205

Committed r220252: <http://trac.webkit.org/changeset/220252>
Comment 9 WebKit Commit Bot 2017-08-03 21:37:16 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2017-08-03 21:38:14 PDT
<rdar://problem/33716804>