Align meta element http-equiv="refresh" parsing with the HTML specification: - https://html.spec.whatwg.org/multipage/semantics.html#attr-meta-http-equiv-refresh
Created attachment 287809 [details] Patch
Comment on attachment 287809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287809&action=review > Source/WebCore/html/parser/HTMLParserIdioms.cpp:305 > + Optional<int> number = parseHTMLNonNegativeInteger(StringView(numberStart, position - numberStart).toStringWithoutCopying()); We need to change parseHTMLNonNegativeInteger to take a StringView; it’s terrible to allocate memory to do this operation! I particularly thing it’s peculiar to make this entire function a template based on character type, which we should only do if the code is really performance-sensitive, and then allocate memory just to parse an integer! > Source/WebCore/platform/network/HTTPParsers.h:81 > -bool parseHTTPRefresh(const String& refresh, bool fromHttpEquivMeta, double& delay, String& url); > +bool parseHTTPRefresh(const String& refresh, double& delay, String& url); I don’t understand why two separate parsers is the way to go here. Do we really need both?
Comment on attachment 287809 [details] Patch Clearing flags on attachment: 287809 Committed r205400: <http://trac.webkit.org/changeset/205400>
All reviewed patches have been landed. Closing bug.