WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
174860
[TexMap] Remove use of GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=174860
Summary
[TexMap] Remove use of GraphicsContext3D
Zan Dobersek
Reported
2017-07-26 04:55:58 PDT
The TextureMapper subsystem depends on the GraphicsContext3D class for performing OpenGL operations. It really shouldn't since that class is tailored to WebGL needs, and carries along costs like ANGLE support. Instead, GraphicsContext3D usage in TextureMapper should be replaced with direct usage of OpenGL APIs.
Attachments
WIP patch
(94.68 KB, patch)
2017-08-01 05:25 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Patch
(49.42 KB, patch)
2017-11-15 07:26 PST
,
Miguel Gomez
no flags
Details
Formatted Diff
Diff
Patch
(49.54 KB, patch)
2017-11-16 01:24 PST
,
Miguel Gomez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2017-08-01 05:25:27 PDT
Created
attachment 316846
[details]
WIP patch
Miguel Gomez
Comment 2
2017-11-15 07:26:09 PST
Created
attachment 326982
[details]
Patch
Build Bot
Comment 3
2017-11-15 07:27:45 PST
Attachment 326982
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:172: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Miguel Gomez
Comment 4
2017-11-16 01:24:24 PST
Created
attachment 327052
[details]
Patch
Build Bot
Comment 5
2017-11-16 01:27:05 PST
Attachment 327052
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:176: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 6
2017-11-16 04:22:51 PST
Comment on
attachment 327052
[details]
Patch Clearing flags on attachment: 327052 Committed
r224912
: <
https://trac.webkit.org/changeset/224912
>
WebKit Commit Bot
Comment 7
2017-11-16 04:22:52 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8
2017-11-16 04:23:27 PST
<
rdar://problem/35586444
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug