Bug 174860 - [TexMap] Remove use of GraphicsContext3D
Summary: [TexMap] Remove use of GraphicsContext3D
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on: 174774 174776 175310 175311 175313 175314 175317 175319 175425
Blocks: 166968
  Show dependency treegraph
 
Reported: 2017-07-26 04:55 PDT by Zan Dobersek
Modified: 2017-11-16 04:23 PST (History)
5 users (show)

See Also:


Attachments
WIP patch (94.68 KB, patch)
2017-08-01 05:25 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (49.42 KB, patch)
2017-11-15 07:26 PST, Miguel Gomez
no flags Details | Formatted Diff | Diff
Patch (49.54 KB, patch)
2017-11-16 01:24 PST, Miguel Gomez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-07-26 04:55:58 PDT
The TextureMapper subsystem depends on the GraphicsContext3D class for performing OpenGL operations. It really shouldn't since that class is tailored to WebGL needs, and carries along costs like ANGLE support.

Instead, GraphicsContext3D usage in TextureMapper should be replaced with direct usage of OpenGL APIs.
Comment 1 Zan Dobersek 2017-08-01 05:25:27 PDT
Created attachment 316846 [details]
WIP patch
Comment 2 Miguel Gomez 2017-11-15 07:26:09 PST
Created attachment 326982 [details]
Patch
Comment 3 Build Bot 2017-11-15 07:27:45 PST
Attachment 326982 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:172:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Miguel Gomez 2017-11-16 01:24:24 PST
Created attachment 327052 [details]
Patch
Comment 5 Build Bot 2017-11-16 01:27:05 PST
Attachment 327052 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:176:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Commit Bot 2017-11-16 04:22:51 PST
Comment on attachment 327052 [details]
Patch

Clearing flags on attachment: 327052

Committed r224912: <https://trac.webkit.org/changeset/224912>
Comment 7 WebKit Commit Bot 2017-11-16 04:22:52 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-11-16 04:23:27 PST
<rdar://problem/35586444>